You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Girish Shilamkar <gi...@clogeny.com> on 2013/08/26 15:05:43 UTC
Review Request 13806: CLOUDSTACK-4407: Use extractTemplate API to get
hypervisor specific template information
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13806/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Bugs: CLOUDSTACK-4407
Repository: cloudstack-git
Description
-------
Template url, hypervisor and format were defined in Service class to be Xenserver specific
and therefore registering a new template failed on Vmware and KVM.
Fixed this to get hypervisor specific info for registering new template.
TODO: Update other tests to use the new function get_builtin_template_info
Diffs
-----
test/integration/component/test_templates.py e4599d4
tools/marvin/marvin/integration/lib/base.py b5d086b
tools/marvin/marvin/integration/lib/common.py 4f5acef
Diff: https://reviews.apache.org/r/13806/diff/
Testing
-------
Thanks,
Girish Shilamkar
Re: Review Request 13806: CLOUDSTACK-4407: Use extractTemplate API to get
hypervisor specific template information
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13806/#review27059
-----------------------------------------------------------
Ship it!
Ship It!
- SrikanteswaraRao Talluri
On Oct. 15, 2013, 6:42 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13806/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2013, 6:42 a.m.)
>
>
> Review request for cloudstack, venkata swamy babu budumuru and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-4407
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Template url, hypervisor and format were defined in Service class to be Xenserver specific
> and therefore registering a new template failed on Vmware and KVM.
> Fixed this to get hypervisor specific info for registering new template.
>
> TODO: Update other tests to use the new function get_builtin_template_info
>
>
> Diffs
> -----
>
> test/integration/component/test_accounts.py 1af408e
> test/integration/component/test_blocker_bugs.py 2cdc270
> test/integration/component/test_stopped_vm.py 41eeb46
>
> Diff: https://reviews.apache.org/r/13806/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 13806: CLOUDSTACK-4407: Use extractTemplate API to get
hypervisor specific template information
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13806/
-----------------------------------------------------------
(Updated Oct. 15, 2013, 6:42 a.m.)
Review request for cloudstack, venkata swamy babu budumuru and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-4407
Repository: cloudstack-git
Description
-------
Template url, hypervisor and format were defined in Service class to be Xenserver specific
and therefore registering a new template failed on Vmware and KVM.
Fixed this to get hypervisor specific info for registering new template.
TODO: Update other tests to use the new function get_builtin_template_info
Diffs
-----
test/integration/component/test_accounts.py 1af408e
test/integration/component/test_blocker_bugs.py 2cdc270
test/integration/component/test_stopped_vm.py 41eeb46
Diff: https://reviews.apache.org/r/13806/diff/
Testing
-------
Thanks,
Girish Shilamkar
Re: Review Request 13806: CLOUDSTACK-4407: Use extractTemplate API to get
hypervisor specific template information
Posted by Chandan Purushothama <Ch...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13806/#review26941
-----------------------------------------------------------
test_stopped_vm.py tries to clean up ISOs that are already deleted as part of Account Deletion. Do not add iso object to the cleanup list.
The other two test scripts "test_accounts.py" and "test_blocker_bugs.py" have been executed against a KVM deployment and tested.
- Chandan Purushothama
On Sept. 12, 2013, 9:47 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13806/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2013, 9:47 a.m.)
>
>
> Review request for cloudstack, venkata swamy babu budumuru, SrikanteswaraRao Talluri, and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4407
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Template url, hypervisor and format were defined in Service class to be Xenserver specific
> and therefore registering a new template failed on Vmware and KVM.
> Fixed this to get hypervisor specific info for registering new template.
>
> TODO: Update other tests to use the new function get_builtin_template_info
>
>
> Diffs
> -----
>
> test/integration/component/test_accounts.py 1af408e
> test/integration/component/test_blocker_bugs.py 2cdc270
> test/integration/component/test_stopped_vm.py 41eeb46
>
> Diff: https://reviews.apache.org/r/13806/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 13806: CLOUDSTACK-4407: Use extractTemplate API to get
hypervisor specific template information
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13806/
-----------------------------------------------------------
(Updated Sept. 12, 2013, 9:47 a.m.)
Review request for cloudstack, venkata swamy babu budumuru, SrikanteswaraRao Talluri, and Prasanna Santhanam.
Bugs: CLOUDSTACK-4407
Repository: cloudstack-git
Description
-------
Template url, hypervisor and format were defined in Service class to be Xenserver specific
and therefore registering a new template failed on Vmware and KVM.
Fixed this to get hypervisor specific info for registering new template.
TODO: Update other tests to use the new function get_builtin_template_info
Diffs
-----
test/integration/component/test_accounts.py 1af408e
test/integration/component/test_blocker_bugs.py 2cdc270
test/integration/component/test_stopped_vm.py 41eeb46
Diff: https://reviews.apache.org/r/13806/diff/
Testing
-------
Thanks,
Girish Shilamkar
Re: Review Request 13806: CLOUDSTACK-4407: Use extractTemplate API to get
hypervisor specific template information
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13806/
-----------------------------------------------------------
(Updated Sept. 11, 2013, 5:20 a.m.)
Review request for cloudstack and Prasanna Santhanam.
Changes
-------
Cloudstack:4407 - Pending changes - Use extractTemplate API
to get hypervisor specific template information in test_accounts.py, test_blocker_bugs.py and test_stopped_vm.py
Bugs: CLOUDSTACK-4407
Repository: cloudstack-git
Description
-------
Template url, hypervisor and format were defined in Service class to be Xenserver specific
and therefore registering a new template failed on Vmware and KVM.
Fixed this to get hypervisor specific info for registering new template.
TODO: Update other tests to use the new function get_builtin_template_info
Diffs (updated)
-----
test/integration/component/test_accounts.py 1af408e
test/integration/component/test_blocker_bugs.py 2cdc270
test/integration/component/test_stopped_vm.py 41eeb46
Diff: https://reviews.apache.org/r/13806/diff/
Testing
-------
Thanks,
Girish Shilamkar
Re: Review Request 13806: CLOUDSTACK-4407: Use extractTemplate API to get
hypervisor specific template information
Posted by Girish Shilamkar <gi...@clogeny.com>.
> On Aug. 29, 2013, 7:09 a.m., Prasanna Santhanam wrote:
> > Do you want to fix the other test suites listed in the bug report with different patches? The problem with the hypervisor-specific template exists in other suites as in the bug report.
I almost forgot about other tests to be updated. I will upload a different patch.
- Girish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13806/#review25715
-----------------------------------------------------------
On Aug. 28, 2013, 8:02 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13806/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 8:02 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4407
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Template url, hypervisor and format were defined in Service class to be Xenserver specific
> and therefore registering a new template failed on Vmware and KVM.
> Fixed this to get hypervisor specific info for registering new template.
>
> TODO: Update other tests to use the new function get_builtin_template_info
>
>
> Diffs
> -----
>
> test/integration/component/test_templates.py e4599d4
> tools/marvin/marvin/integration/lib/base.py b5d086b
> tools/marvin/marvin/integration/lib/common.py 4f5acef
>
> Diff: https://reviews.apache.org/r/13806/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 13806: CLOUDSTACK-4407: Use extractTemplate API to get
hypervisor specific template information
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13806/#review25715
-----------------------------------------------------------
Do you want to fix the other test suites listed in the bug report with different patches? The problem with the hypervisor-specific template exists in other suites as in the bug report.
- Prasanna Santhanam
On Aug. 28, 2013, 8:02 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13806/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 8:02 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4407
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Template url, hypervisor and format were defined in Service class to be Xenserver specific
> and therefore registering a new template failed on Vmware and KVM.
> Fixed this to get hypervisor specific info for registering new template.
>
> TODO: Update other tests to use the new function get_builtin_template_info
>
>
> Diffs
> -----
>
> test/integration/component/test_templates.py e4599d4
> tools/marvin/marvin/integration/lib/base.py b5d086b
> tools/marvin/marvin/integration/lib/common.py 4f5acef
>
> Diff: https://reviews.apache.org/r/13806/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 13806: CLOUDSTACK-4407: Use extractTemplate API to get
hypervisor specific template information
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13806/#review25718
-----------------------------------------------------------
Commit de86e5e63dcb5f11c139acf4f0f027fbecbaa00d in branch refs/heads/4.2-forward from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=de86e5e ]
CLOUDSTACK-4407: Use extractTemplate API to get hypervisor specific template information
Template url, hypervisor and format were defined in Service class to be Xenserver specific
and therefore registering a new template failed on Vmware and KVM.
Fixed this to get hypervisor specific info for registering new template.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit 20256706b376551fe8993ee2e73c61df31dcb6de)
- ASF Subversion and Git Services
On Aug. 28, 2013, 8:02 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13806/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 8:02 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4407
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Template url, hypervisor and format were defined in Service class to be Xenserver specific
> and therefore registering a new template failed on Vmware and KVM.
> Fixed this to get hypervisor specific info for registering new template.
>
> TODO: Update other tests to use the new function get_builtin_template_info
>
>
> Diffs
> -----
>
> test/integration/component/test_templates.py e4599d4
> tools/marvin/marvin/integration/lib/base.py b5d086b
> tools/marvin/marvin/integration/lib/common.py 4f5acef
>
> Diff: https://reviews.apache.org/r/13806/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 13806: CLOUDSTACK-4407: Use extractTemplate API to get
hypervisor specific template information
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13806/#review25720
-----------------------------------------------------------
Commit c6f0d46911143ef79bec86d4b989d9256f15b29e in branch refs/heads/master from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c6f0d46 ]
CLOUDSTACK-4407: Use extractTemplate API to get hypervisor specific template information
Template url, hypervisor and format were defined in Service class to be Xenserver specific
and therefore registering a new template failed on Vmware and KVM.
Fixed this to get hypervisor specific info for registering new template.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit 20256706b376551fe8993ee2e73c61df31dcb6de)
- ASF Subversion and Git Services
On Aug. 28, 2013, 8:02 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13806/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 8:02 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4407
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Template url, hypervisor and format were defined in Service class to be Xenserver specific
> and therefore registering a new template failed on Vmware and KVM.
> Fixed this to get hypervisor specific info for registering new template.
>
> TODO: Update other tests to use the new function get_builtin_template_info
>
>
> Diffs
> -----
>
> test/integration/component/test_templates.py e4599d4
> tools/marvin/marvin/integration/lib/base.py b5d086b
> tools/marvin/marvin/integration/lib/common.py 4f5acef
>
> Diff: https://reviews.apache.org/r/13806/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 13806: CLOUDSTACK-4407: Use extractTemplate API to get
hypervisor specific template information
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13806/
-----------------------------------------------------------
(Updated Aug. 28, 2013, 8:02 a.m.)
Review request for cloudstack and Prasanna Santhanam.
Bugs: CLOUDSTACK-4407
Repository: cloudstack-git
Description
-------
Template url, hypervisor and format were defined in Service class to be Xenserver specific
and therefore registering a new template failed on Vmware and KVM.
Fixed this to get hypervisor specific info for registering new template.
TODO: Update other tests to use the new function get_builtin_template_info
Diffs (updated)
-----
test/integration/component/test_templates.py e4599d4
tools/marvin/marvin/integration/lib/base.py b5d086b
tools/marvin/marvin/integration/lib/common.py 4f5acef
Diff: https://reviews.apache.org/r/13806/diff/
Testing
-------
Thanks,
Girish Shilamkar
Re: Review Request 13806: CLOUDSTACK-4407: Use extractTemplate API to get
hypervisor specific template information
Posted by Girish Shilamkar <gi...@clogeny.com>.
> On Aug. 27, 2013, 5:33 a.m., Prasanna Santhanam wrote:
> > tools/marvin/marvin/integration/lib/common.py, line 241
> > <https://reviews.apache.org/r/13806/diff/1/?file=344717#file344717line241>
> >
> > Please use Template.list. The list_templates (form of) method is redundant and should be deprecated. Also check that your template is extractable else raise an Exception.
I will make it Template.list, template is registered as extractable.
- Girish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13806/#review25551
-----------------------------------------------------------
On Aug. 26, 2013, 1:05 p.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13806/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2013, 1:05 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4407
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Template url, hypervisor and format were defined in Service class to be Xenserver specific
> and therefore registering a new template failed on Vmware and KVM.
> Fixed this to get hypervisor specific info for registering new template.
>
> TODO: Update other tests to use the new function get_builtin_template_info
>
>
> Diffs
> -----
>
> test/integration/component/test_templates.py e4599d4
> tools/marvin/marvin/integration/lib/base.py b5d086b
> tools/marvin/marvin/integration/lib/common.py 4f5acef
>
> Diff: https://reviews.apache.org/r/13806/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 13806: CLOUDSTACK-4407: Use extractTemplate API to get
hypervisor specific template information
Posted by Girish Shilamkar <gi...@clogeny.com>.
> On Aug. 27, 2013, 5:33 a.m., Prasanna Santhanam wrote:
> > tools/marvin/marvin/integration/lib/base.py, line 891
> > <https://reviews.apache.org/r/13806/diff/1/?file=344716#file344716line891>
> >
> > extract works on an existing Image/Template. Why should it be a classmethod?
> >
> >
list_template does not return template object, it returns json loader object. Therefore I had to define it a classmethod.
- Girish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13806/#review25551
-----------------------------------------------------------
On Aug. 26, 2013, 1:05 p.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13806/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2013, 1:05 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4407
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Template url, hypervisor and format were defined in Service class to be Xenserver specific
> and therefore registering a new template failed on Vmware and KVM.
> Fixed this to get hypervisor specific info for registering new template.
>
> TODO: Update other tests to use the new function get_builtin_template_info
>
>
> Diffs
> -----
>
> test/integration/component/test_templates.py e4599d4
> tools/marvin/marvin/integration/lib/base.py b5d086b
> tools/marvin/marvin/integration/lib/common.py 4f5acef
>
> Diff: https://reviews.apache.org/r/13806/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 13806: CLOUDSTACK-4407: Use extractTemplate API to get
hypervisor specific template information
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13806/#review25551
-----------------------------------------------------------
tools/marvin/marvin/integration/lib/base.py
<https://reviews.apache.org/r/13806/#comment50015>
extract works on an existing Image/Template. Why should it be a classmethod?
tools/marvin/marvin/integration/lib/common.py
<https://reviews.apache.org/r/13806/#comment50018>
What is the purpose of account/domainid? since all accounts have access to the default builtin?
Also you cannot use the templatefilter=all if the apiclient is that of a non-admin user. Try 'featured'/'public'
tools/marvin/marvin/integration/lib/common.py
<https://reviews.apache.org/r/13806/#comment50016>
Please add a help/ docstring
tools/marvin/marvin/integration/lib/common.py
<https://reviews.apache.org/r/13806/#comment50017>
Please use Template.list. The list_templates (form of) method is redundant and should be deprecated. Also check that your template is extractable else raise an Exception.
- Prasanna Santhanam
On Aug. 26, 2013, 1:05 p.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13806/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2013, 1:05 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4407
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Template url, hypervisor and format were defined in Service class to be Xenserver specific
> and therefore registering a new template failed on Vmware and KVM.
> Fixed this to get hypervisor specific info for registering new template.
>
> TODO: Update other tests to use the new function get_builtin_template_info
>
>
> Diffs
> -----
>
> test/integration/component/test_templates.py e4599d4
> tools/marvin/marvin/integration/lib/base.py b5d086b
> tools/marvin/marvin/integration/lib/common.py 4f5acef
>
> Diff: https://reviews.apache.org/r/13806/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>