You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Salvatore Orlando <so...@nicira.com> on 2012/07/23 19:57:12 UTC
Review Request: Ensure correct class name is specified in components.xml.in
for NiciraNvpElementService
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6094/
-----------------------------------------------------------
Review request for cloudstack, Hugo Trippaers and Somik Behera.
Description
-------
Addresses CS-15664 (http://bugs.cloudstack.org/browse/CS-15664)
Fixes typo in Fully Qualified class name for NiciraNVPElementService.
Also address similar typo for CiscoNexusVsmElement
Diffs
-----
client/tomcatconf/components.xml.in 16d7b19
Diff: https://reviews.apache.org/r/6094/diff/
Testing
-------
After observing crash while preparing the network on a physical network with STT isolation method, components.xml.in was fixed. The CloudStack was then re-built and re-deployed, and the crash while preparing the network was not observed anymore.
Thanks,
Salvatore Orlando
Re: Review Request: Ensure correct class name is specified in
components.xml.in for NiciraNvpElementService
Posted by Hugo Trippaers <HT...@schubergphilis.com>.
Nice find :-)
Thanks!
Cheers,
Hugo
Sent from my iPhone
On 24 jul. 2012, at 03:30, "Salvatore Orlando" <so...@nicira.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6094/
> -----------------------------------------------------------
>
> (Updated July 24, 2012, 1:30 a.m.)
>
>
> Review request for cloudstack, Hugo Trippaers and Somik Behera.
>
>
> Description
> -------
>
> Addresses CS-15664 (http://bugs.cloudstack.org/browse/CS-15664)
> Fixes typo in Fully Qualified class name for NiciraNVPElementService.
>
> Also address similar typo for CiscoNexusVsmElement
>
>
> This addresses bug CS-15664.
>
>
> Diffs
> -----
>
> client/tomcatconf/components.xml.in 16d7b19
>
> Diff: https://reviews.apache.org/r/6094/diff/
>
>
> Testing
> -------
>
> After observing crash while preparing the network on a physical network with STT isolation method, components.xml.in was fixed. The CloudStack was then re-built and re-deployed, and the crash while preparing the network was not observed anymore.
>
>
> Thanks,
>
> Salvatore Orlando
>
Re: Review Request: Ensure correct class name is specified in
components.xml.in for NiciraNvpElementService
Posted by Salvatore Orlando <so...@nicira.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6094/
-----------------------------------------------------------
(Updated July 24, 2012, 1:30 a.m.)
Review request for cloudstack, Hugo Trippaers and Somik Behera.
Description
-------
Addresses CS-15664 (http://bugs.cloudstack.org/browse/CS-15664)
Fixes typo in Fully Qualified class name for NiciraNVPElementService.
Also address similar typo for CiscoNexusVsmElement
This addresses bug CS-15664.
Diffs
-----
client/tomcatconf/components.xml.in 16d7b19
Diff: https://reviews.apache.org/r/6094/diff/
Testing
-------
After observing crash while preparing the network on a physical network with STT isolation method, components.xml.in was fixed. The CloudStack was then re-built and re-deployed, and the crash while preparing the network was not observed anymore.
Thanks,
Salvatore Orlando
Re: Review Request: Ensure correct class name is specified in
components.xml.in for NiciraNvpElementService
Posted by Somik Behera <so...@nicira.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6094/#review9366
-----------------------------------------------------------
Ship it!
Thanks for fixing this Salvatore! The patch looks good.
- Somik Behera
On July 23, 2012, 5:57 p.m., Salvatore Orlando wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6094/
> -----------------------------------------------------------
>
> (Updated July 23, 2012, 5:57 p.m.)
>
>
> Review request for cloudstack, Hugo Trippaers and Somik Behera.
>
>
> Description
> -------
>
> Addresses CS-15664 (http://bugs.cloudstack.org/browse/CS-15664)
> Fixes typo in Fully Qualified class name for NiciraNVPElementService.
>
> Also address similar typo for CiscoNexusVsmElement
>
>
> Diffs
> -----
>
> client/tomcatconf/components.xml.in 16d7b19
>
> Diff: https://reviews.apache.org/r/6094/diff/
>
>
> Testing
> -------
>
> After observing crash while preparing the network on a physical network with STT isolation method, components.xml.in was fixed. The CloudStack was then re-built and re-deployed, and the crash while preparing the network was not observed anymore.
>
>
> Thanks,
>
> Salvatore Orlando
>
>