[jira] [Commented] (FLINK-12297) Clean the closure for OutputTags in PatternStream

["Aljoscha Krettek (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847590#comment-16847590 ] 

Aljoscha Krettek commented on FLINK-12297:
------------------------------------------

{{OutputTag}} needs to be an anonymous inner class (or a concrete subclass, at least) so that the Java compiler will put the information about the generic parameters in the generated code. Thats why you see {{new OutputTag<T>()}}, notice the {{{}}}. 

> Clean the closure for OutputTags in PatternStream
> -------------------------------------------------
>
>                 Key: FLINK-12297
>                 URL: https://issues.apache.org/jira/browse/FLINK-12297
>             Project: Flink
>          Issue Type: Bug
>          Components: Library / CEP
>    Affects Versions: 1.8.0
>            Reporter: Dawid Wysakowicz
>            Assignee: aitozi
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.9.0, 1.8.1
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Right now we do not invoke closure cleaner on output tags. Therefore such code:
> {code}
> 	@Test
> 	public void testFlatSelectSerialization() throws Exception {
> 		StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
> 		DataStreamSource<Integer> elements = env.fromElements(1, 2, 3);
> 		OutputTag<Integer> outputTag = new OutputTag<Integer>("AAA") {};
> 		CEP.pattern(elements, Pattern.begin("A")).flatSelect(
> 			outputTag,
> 			new PatternFlatTimeoutFunction<Integer, Integer>() {
> 				@Override
> 				public void timeout(
> 					Map<String, List<Integer>> pattern,
> 					long timeoutTimestamp,
> 					Collector<Integer> out) throws Exception {
> 				}
> 			},
> 			new PatternFlatSelectFunction<Integer, Object>() {
> 				@Override
> 				public void flatSelect(Map<String, List<Integer>> pattern, Collector<Object> out) throws Exception {
> 				}
> 			}
> 		);
> 		env.execute();
> 	}
> {code}
> will fail with {{The implementation of the PatternFlatSelectAdapter is not serializable. }} exception



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)