You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/02/23 15:40:37 UTC
[GitHub] [hive] belugabehr opened a new pull request #2009: HIVE-24814: Harmonize Hive Date-Time Formats
belugabehr opened a new pull request #2009:
URL: https://github.com/apache/hive/pull/2009
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on a change in pull request #2009: HIVE-24814: Harmonize Hive Date-Time Formats
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #2009:
URL: https://github.com/apache/hive/pull/2009#discussion_r585545605
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastTimestampToString.java
##########
@@ -28,20 +28,12 @@
import java.time.ZoneOffset;
import java.time.format.DateTimeFormatter;
import java.time.format.DateTimeFormatterBuilder;
-import java.time.temporal.ChronoField;
public class CastTimestampToString extends TimestampToStringUnaryUDF {
private static final long serialVersionUID = 1L;
- private static final DateTimeFormatter PRINT_FORMATTER;
-
- static {
- DateTimeFormatterBuilder builder = new DateTimeFormatterBuilder();
- // Date and time parts
- builder.append(DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss"));
- // Fractional part
- builder.optionalStart().appendFraction(ChronoField.NANO_OF_SECOND, 0, 9, true).optionalEnd();
- PRINT_FORMATTER = builder.toFormatter();
- }
+ private static final DateTimeFormatter PRINT_FORMATTER =
+ new DateTimeFormatterBuilder().append(DateTimeFormatter.ISO_LOCAL_DATE).appendLiteral(' ')
+ .append(DateTimeFormatter.ISO_LOCAL_TIME).toFormatter();
Review comment:
is optional Nanotime included in ISO_LOCAL_TIME ? Looks likes its already there: ``.appendFraction(NANO_OF_SECOND, 0, 9, true)``
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on pull request #2009: HIVE-24814: Harmonize Hive Date-Time Formats
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #2009:
URL: https://github.com/apache/hive/pull/2009#issuecomment-788895303
Hey @belugabehr can you please take another look on the .out diffs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #2009: HIVE-24814: Harmonize Hive Date-Time Formats
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #2009:
URL: https://github.com/apache/hive/pull/2009#issuecomment-855489242
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr closed pull request #2009: HIVE-24814: Harmonize Hive Date-Time Formats
Posted by GitBox <gi...@apache.org>.
belugabehr closed pull request #2009:
URL: https://github.com/apache/hive/pull/2009
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #2009: HIVE-24814: Harmonize Hive Date-Time Formats
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #2009:
URL: https://github.com/apache/hive/pull/2009#issuecomment-894573586
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on a change in pull request #2009: HIVE-24814: Harmonize Hive Date-Time Formats
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #2009:
URL: https://github.com/apache/hive/pull/2009#discussion_r585545605
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastTimestampToString.java
##########
@@ -28,20 +28,12 @@
import java.time.ZoneOffset;
import java.time.format.DateTimeFormatter;
import java.time.format.DateTimeFormatterBuilder;
-import java.time.temporal.ChronoField;
public class CastTimestampToString extends TimestampToStringUnaryUDF {
private static final long serialVersionUID = 1L;
- private static final DateTimeFormatter PRINT_FORMATTER;
-
- static {
- DateTimeFormatterBuilder builder = new DateTimeFormatterBuilder();
- // Date and time parts
- builder.append(DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss"));
- // Fractional part
- builder.optionalStart().appendFraction(ChronoField.NANO_OF_SECOND, 0, 9, true).optionalEnd();
- PRINT_FORMATTER = builder.toFormatter();
- }
+ private static final DateTimeFormatter PRINT_FORMATTER =
+ new DateTimeFormatterBuilder().append(DateTimeFormatter.ISO_LOCAL_DATE).appendLiteral(' ')
+ .append(DateTimeFormatter.ISO_LOCAL_TIME).toFormatter();
Review comment:
is optional Nanotime included in ISO_LOCAL_TIME ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on pull request #2009: HIVE-24814: Harmonize Hive Date-Time Formats
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #2009:
URL: https://github.com/apache/hive/pull/2009#issuecomment-788939546
@pgaref Thanks for your interest (as always).
The Time parsing/formatting code is all over the place in Hive. Did you know there are some areas of the code that allow for 10 digits of nanos, by truncating the last digit, but not others?
I am trying to consolidate all that stuff and bring it into one place for visibility and trying to harmonize it with the pre-canned ISO formats already included in the JDK. The less Hive-specific stuff regarding time handling, the better. I also plan on adding copious documentation once I get the unit tests all working. I know some of them are broken. I'm having a pretty hard time figuring out where they are going wrong.
And yes `ISO_LOCAL_TIME` includes an optional NANO field. This will be mentioned in comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #2009: HIVE-24814: Harmonize Hive Date-Time Formats
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #2009:
URL: https://github.com/apache/hive/pull/2009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org