[jira] [Resolved] (IMPALA-7319) Investigate Clang Tidy Diff

["Joe McDonnell (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-7319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe McDonnell resolved IMPALA-7319.
-----------------------------------
    Fix Version/s: Not Applicable
       Resolution: Won't Fix

The clang tidy job in upstream GVO already provides pretty fast feedback. I'm going to close this.

> Investigate Clang Tidy Diff
> ---------------------------
>
>                 Key: IMPALA-7319
>                 URL: https://issues.apache.org/jira/browse/IMPALA-7319
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: Impala 3.1.0
>            Reporter: Joe McDonnell
>            Priority: Minor
>             Fix For: Not Applicable
>
>
> Clang has a script clang-tidy-diff.py that can run clang tidy on a diff. This is substantially faster than the normal run-clang-tidy.py, because it compiles and analyzes only the changed files. This might also allow a more graceful way to incorporate new clang tidy checks. Kudu has implemented this functionality in their project. See [build-support/clang_tidy_gerrit.py|[https://github.com/apache/kudu/blob/master/build-support/clang_tidy_gerrit.py].] 
> While this is faster, it is possible to have a code change that introduces a clang tidy issue in code that didn't change, so clang tidy on a diff might miss some issues.
> We should evaluate whether this is something worth incorporating into Impala. It could be a good way for a developer to do a quick check before upload to Gerrit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)