You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/06/20 13:36:21 UTC

[GitHub] [tinkerpop] spmallette commented on pull request #1697: TINKERPOP-2734 Fix potential SessionedClient NPE

spmallette commented on PR #1697:
URL: https://github.com/apache/tinkerpop/pull/1697#issuecomment-1160459458

   generally speaking, i don't really see anything wrong with this change. i dont' think it introduces anything bad and the decoupling of logic is probably a good idea. could we question the theory of this change a bit though? i suppose the assumption here that `connectionPool` is somehow `null` when it gets to `SessionedClient.chooseConnection()` and that is the NPE. if so, what circumstance allows that to happen and how does this change either potentially fix or better expose that problem? 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org