You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vaibhav Gumashta <vg...@hortonworks.com> on 2017/10/02 20:27:23 UTC
Re: Review Request 62695: HIVE-17649: Export/Import: Move export data
write to a task
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62695/
-----------------------------------------------------------
(Updated Oct. 2, 2017, 8:27 p.m.)
Review request for hive and Thejas Nair.
Bugs: HIVE-17649
https://issues.apache.org/jira/browse/HIVE-17649
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-17649
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/ExportTask.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java fe9b624
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java f9991d9
ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java b8c6ea9
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java ed43272
ql/src/java/org/apache/hadoop/hive/ql/plan/ExportWork.java PRE-CREATION
ql/src/test/results/clientnegative/authorization_uri_export.q.out 19c8115
ql/src/test/results/clientnegative/exim_12_nonnative_export.q.out 5da4daa
Diff: https://reviews.apache.org/r/62695/diff/2/
Changes: https://reviews.apache.org/r/62695/diff/1-2/
Testing
-------
Thanks,
Vaibhav Gumashta
Re: Review Request 62695: HIVE-17649: Export/Import: Move export data
write to a task
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62695/#review186904
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java
Line 62 (original), 62 (patched)
<https://reviews.apache.org/r/62695/#comment263781>
can you also remove this member variable?
- Thejas Nair
On Oct. 2, 2017, 8:27 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62695/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 8:27 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-17649
> https://issues.apache.org/jira/browse/HIVE-17649
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-17649
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/ExportTask.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java fe9b624
> ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java f9991d9
> ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java b8c6ea9
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java ed43272
> ql/src/java/org/apache/hadoop/hive/ql/plan/ExportWork.java PRE-CREATION
> ql/src/test/results/clientnegative/authorization_uri_export.q.out 19c8115
> ql/src/test/results/clientnegative/exim_12_nonnative_export.q.out 5da4daa
>
>
> Diff: https://reviews.apache.org/r/62695/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 62695: HIVE-17649: Export/Import: Move export data
write to a task
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62695/#review186914
-----------------------------------------------------------
Ship it!
Ship It!
- Thejas Nair
On Oct. 2, 2017, 10:55 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62695/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 10:55 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-17649
> https://issues.apache.org/jira/browse/HIVE-17649
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-17649
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/ExportTask.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java fe9b624
> ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java f9991d9
> ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java b8c6ea9
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/PartitionExport.java 7e72f23
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java ed43272
> ql/src/java/org/apache/hadoop/hive/ql/plan/ExportWork.java PRE-CREATION
> ql/src/test/results/clientnegative/authorization_uri_export.q.out 19c8115
> ql/src/test/results/clientnegative/exim_12_nonnative_export.q.out 5da4daa
>
>
> Diff: https://reviews.apache.org/r/62695/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 62695: HIVE-17649: Export/Import: Move export data
write to a task
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62695/
-----------------------------------------------------------
(Updated Oct. 2, 2017, 10:55 p.m.)
Review request for hive and Thejas Nair.
Bugs: HIVE-17649
https://issues.apache.org/jira/browse/HIVE-17649
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-17649
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/ExportTask.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java fe9b624
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java f9991d9
ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java b8c6ea9
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/PartitionExport.java 7e72f23
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java ed43272
ql/src/java/org/apache/hadoop/hive/ql/plan/ExportWork.java PRE-CREATION
ql/src/test/results/clientnegative/authorization_uri_export.q.out 19c8115
ql/src/test/results/clientnegative/exim_12_nonnative_export.q.out 5da4daa
Diff: https://reviews.apache.org/r/62695/diff/3/
Changes: https://reviews.apache.org/r/62695/diff/2-3/
Testing
-------
Thanks,
Vaibhav Gumashta