You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/28 15:30:37 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #12669: ARROW-15974: [C++] Migrate flight/types.h header definitions to use Result<>

pitrou commented on a change in pull request #12669:
URL: https://github.com/apache/arrow/pull/12669#discussion_r836557021



##########
File path: cpp/src/arrow/flight/flight_internals_test.cc
##########
@@ -177,6 +175,25 @@ TEST(FlightTypes, RoundtripStatus) {
   ASSERT_THAT(status.message(), ::testing::HasSubstr("Sentinel"));
 }
 
+ARROW_SUPPRESS_DEPRECATION_WARNING
+TEST(FlightTypes, DeprecatedLocationConstruction) {
+  Location location;
+  ASSERT_NOT_OK(Location::Parse("This is not an URI", &location));

Review comment:
       Can we use a more restrictive test here, e.g.:
   ```suggestion
     ASSERT_RAISES(Invalid, Location::Parse("This is not an URI", &location));
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org