You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "123123213weqw (via GitHub)" <gi...@apache.org> on 2026/08/21 08:07:32 UTC

[I] [Studio][Bug] Allow clearing persisted Topic remarks [rocketmq-dashboard]

123123213weqw opened a new issue, #2497:
URL: https://github.com/apache/rocketmq-dashboard/issues/2497

   ## Problem
   
   The remark is only updated when `StringUtils.hasText(remark)`. When a user submits an empty string to clear the remark, the old remark is kept.
   
   Location: `server/src/main/java/org/apache/rocketmq/studio/provider/apache/RocketMQAdminClientImpl.java`.
   
   ## Expected behavior
   
   Distinguish "field not submitted" from "field submitted empty"; update when the field is non-null and normalize an empty string to null/empty.
   
   ## Verification
   
   Remark not submitted stays; blank submission clears; new value replaces.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Studio][Bug] Allow clearing persisted Topic remarks [rocketmq-dashboard]

Posted by "123123213weqw (via GitHub)" <gi...@apache.org>.
123123213weqw commented on issue #2497:
URL: https://github.com/apache/rocketmq-dashboard/issues/2497#issuecomment-5367138243

   Picking this one up, PR coming shortly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Studio][Bug] Allow clearing persisted Topic remarks [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #2497: [Studio][Bug] Allow clearing persisted Topic remarks
URL: https://github.com/apache/rocketmq-dashboard/issues/2497


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Studio][Bug] Allow clearing persisted Topic remarks [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #2497:
URL: https://github.com/apache/rocketmq-dashboard/issues/2497#issuecomment-5459083078

   This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Studio][Bug] Allow clearing persisted Topic remarks [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #2497:
URL: https://github.com/apache/rocketmq-dashboard/issues/2497#issuecomment-5368444925

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   The reported issue has been verified against the current codebase.
   
   **Root Cause:** In `RocketMQAdminClientImpl.updateTopic()` (line ~266), the remark update is guarded by `if (StringUtils.hasText(topic.getRemark()))`. When a user submits an empty string to clear the remark, `StringUtils.hasText("")` returns `false`, so the old remark is preserved.
   
   **Impact:** Users cannot clear topic remarks through the Studio UI. Once set, a remark is permanent.
   
   **Severity:** low
   
   **Suggested Fix:** Distinguish `null` (field not submitted) from empty string (explicitly cleared). Update the remark when the field is non-null, normalizing an empty string to null/empty.
   
   An automated fix proposal will be generated. Reply `/approve` to proceed with PR generation.
   
   ---
   *Automated evaluation by github-manager*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org