You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/04/25 03:21:52 UTC
[GitHub] [ozone] symious opened a new pull request, #3342: HDDS-6640. Node.isAncestor might return incorrect result
symious opened a new pull request, #3342:
URL: https://github.com/apache/ozone/pull/3342
## What changes were proposed in this pull request?
In NodeImpl, the relation of ancestor is decided as follows:
```
@Override
public boolean isAncestor(Node node) {
return this.getNetworkFullPath().equals(PATH_SEPARATOR_STR) ||
node.getNetworkLocation().startsWith(this.getNetworkFullPath()) ||
node.getNetworkFullPath().equalsIgnoreCase(this.getNetworkFullPath());
```
The corner case is as follows:
```
Node n1: "/rc"
Node n2: "/rc1/dc/1.1.1.1"
```
The result of n1.isAncestor(n2) is false, while in fact n1 is not n2's ancestor.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6640
## How was this patch tested?
unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi merged pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
ChenSammi merged PR #3342:
URL: https://github.com/apache/ozone/pull/3342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on PR #3342:
URL: https://github.com/apache/ozone/pull/3342#issuecomment-1116977449
The path LGTM, +1.
Thanks @symious for the contribution and @ayushtkn for the code review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a diff in pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on code in PR #3342:
URL: https://github.com/apache/ozone/pull/3342#discussion_r859354971
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/Node.java:
##########
@@ -98,4 +98,12 @@ public interface Node {
* @return true if this node is an ancestor of <i>n</i>
*/
boolean isAncestor(Node n);
+
+ /**
+ * Judge if this node is under a specific scope.
Review Comment:
Judge if this node is a descendant of the node representing by the nodeLocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on a diff in pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
symious commented on code in PR #3342:
URL: https://github.com/apache/ozone/pull/3342#discussion_r862470317
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NetUtils.java:
##########
@@ -149,4 +149,28 @@ public static List<Node> getAncestorList(NetworkTopology topology,
}
return ancestorList;
}
+
+ /**
+ * Ensure {@link NetConstants#PATH_SEPARATOR_STR} is added to the suffix of
+ * the path.
+ * @param path path to add suffix
+ * @return the normalised path
+ * If <i>path</i>is empty, then {@link NetConstants#ROOT} is returned
+ */
+ public static String addSuffix(String path) {
+ if (path == null) {
+ return null;
+ }
Review Comment:
I think it's a little different here. This method shouldn't change the fact that it's a null. If we return "/" for null strings, `isDescentof(null)` will always return true, which is not what we expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a diff in pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on code in PR #3342:
URL: https://github.com/apache/ozone/pull/3342#discussion_r859353735
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/Node.java:
##########
@@ -98,4 +98,12 @@ public interface Node {
* @return true if this node is an ancestor of <i>n</i>
*/
boolean isAncestor(Node n);
+
+ /**
+ * Judge if this node is under a specific scope.
+ *
+ * @param scope the scope
+ * @return true if this node is under a specific scope
+ */
+ boolean isUnderScope(String scope);
Review Comment:
isUnderScope -> isDescendant
scope -> nodePath
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
symious commented on PR #3342:
URL: https://github.com/apache/ozone/pull/3342#issuecomment-1110591868
Found some other parts need to be fixed, please have a check.
Basically, I changed all usage of `Node.getNetworkFullPath().startsWith(path)` to `isDescendant`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on a diff in pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
symious commented on code in PR #3342:
URL: https://github.com/apache/ozone/pull/3342#discussion_r862469606
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NetUtils.java:
##########
@@ -149,4 +149,28 @@ public static List<Node> getAncestorList(NetworkTopology topology,
}
return ancestorList;
}
+
+ /**
+ * Ensure {@link NetConstants#PATH_SEPARATOR_STR} is added to the suffix of
+ * the path.
+ * @param path path to add suffix
+ * @return the normalised path
+ * If <i>path</i>is empty, then {@link NetConstants#ROOT} is returned
+ */
+ public static String addSuffix(String path) {
+ if (path == null) {
+ return null;
+ }
+
+ int len = path.length();
+ if (len == 0) {
+ return NetConstants.PATH_SEPARATOR_STR;
Review Comment:
Updated the doc to return `PAHT_SEPARATOR_STR` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
symious commented on PR #3342:
URL: https://github.com/apache/ozone/pull/3342#issuecomment-1110546941
@ChenSammi Updated the method name, please have a check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
symious commented on PR #3342:
URL: https://github.com/apache/ozone/pull/3342#issuecomment-1108338142
@ChenSammi The issue also happends in `InnerNodeImpl.getLeafOnLeafParent(...)`.
Created a new method for Node to check if the node is under some scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a diff in pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on code in PR #3342:
URL: https://github.com/apache/ozone/pull/3342#discussion_r859354971
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/Node.java:
##########
@@ -98,4 +98,12 @@ public interface Node {
* @return true if this node is an ancestor of <i>n</i>
*/
boolean isAncestor(Node n);
+
+ /**
+ * Judge if this node is under a specific scope.
Review Comment:
Judge if this node is a descendant of the node representing by the nodePath.
Descendant includes itself and all child generations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a diff in pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on code in PR #3342:
URL: https://github.com/apache/ozone/pull/3342#discussion_r859353735
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/Node.java:
##########
@@ -98,4 +98,12 @@ public interface Node {
* @return true if this node is an ancestor of <i>n</i>
*/
boolean isAncestor(Node n);
+
+ /**
+ * Judge if this node is under a specific scope.
+ *
+ * @param scope the scope
+ * @return true if this node is under a specific scope
+ */
+ boolean isUnderScope(String scope);
Review Comment:
isUnderScope -> isDescendant
scope -> nodeLocation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on a diff in pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
symious commented on code in PR #3342:
URL: https://github.com/apache/ozone/pull/3342#discussion_r857275000
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NodeImpl.java:
##########
@@ -231,4 +231,14 @@ private String getPath() {
this.location + this.name :
this.location + PATH_SEPARATOR_STR + this.name;
}
+
+ public static void main(String[] args) {
Review Comment:
Sure, removed. Please have a check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
symious commented on PR #3342:
URL: https://github.com/apache/ozone/pull/3342#issuecomment-1117136610
Thanks @ChenSammi @ayushtkn for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a diff in pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on code in PR #3342:
URL: https://github.com/apache/ozone/pull/3342#discussion_r859353735
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/Node.java:
##########
@@ -98,4 +98,12 @@ public interface Node {
* @return true if this node is an ancestor of <i>n</i>
*/
boolean isAncestor(Node n);
+
+ /**
+ * Judge if this node is under a specific scope.
+ *
+ * @param scope the scope
+ * @return true if this node is under a specific scope
+ */
+ boolean isUnderScope(String scope);
Review Comment:
isUnderScope -> isDescendant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on a diff in pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on code in PR #3342:
URL: https://github.com/apache/ozone/pull/3342#discussion_r862994720
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NetUtils.java:
##########
@@ -149,4 +149,28 @@ public static List<Node> getAncestorList(NetworkTopology topology,
}
return ancestorList;
}
+
+ /**
+ * Ensure {@link NetConstants#PATH_SEPARATOR_STR} is added to the suffix of
+ * the path.
+ * @param path path to add suffix
+ * @return the normalised path
+ * If <i>path</i>is empty, then {@link NetConstants#ROOT} is returned
+ */
+ public static String addSuffix(String path) {
+ if (path == null) {
+ return null;
+ }
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a diff in pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on code in PR #3342:
URL: https://github.com/apache/ozone/pull/3342#discussion_r857259961
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NodeImpl.java:
##########
@@ -231,4 +231,14 @@ private String getPath() {
this.location + this.name :
this.location + PATH_SEPARATOR_STR + this.name;
}
+
+ public static void main(String[] args) {
Review Comment:
Can we remove this main class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on a diff in pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
symious commented on code in PR #3342:
URL: https://github.com/apache/ozone/pull/3342#discussion_r862469706
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NetUtils.java:
##########
@@ -149,4 +149,28 @@ public static List<Node> getAncestorList(NetworkTopology topology,
}
return ancestorList;
}
+
+ /**
+ * Ensure {@link NetConstants#PATH_SEPARATOR_STR} is added to the suffix of
+ * the path.
+ * @param path path to add suffix
+ * @return the normalised path
+ * If <i>path</i>is empty, then {@link NetConstants#ROOT} is returned
+ */
+ public static String addSuffix(String path) {
+ if (path == null) {
+ return null;
+ }
+
+ int len = path.length();
+ if (len == 0) {
+ return NetConstants.PATH_SEPARATOR_STR;
+ }
+
+ if (path.charAt(len - 1) != NetConstants.PATH_SEPARATOR) {
+ return path + NetConstants.PATH_SEPARATOR_STR;
+ }
+
+ return path;
Review Comment:
Yes, the new code is more succinct, thanks for the advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on a diff in pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on code in PR #3342:
URL: https://github.com/apache/ozone/pull/3342#discussion_r862453964
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NetUtils.java:
##########
@@ -149,4 +149,28 @@ public static List<Node> getAncestorList(NetworkTopology topology,
}
return ancestorList;
}
+
+ /**
+ * Ensure {@link NetConstants#PATH_SEPARATOR_STR} is added to the suffix of
+ * the path.
+ * @param path path to add suffix
+ * @return the normalised path
+ * If <i>path</i>is empty, then {@link NetConstants#ROOT} is returned
+ */
+ public static String addSuffix(String path) {
+ if (path == null) {
+ return null;
+ }
+
+ int len = path.length();
+ if (len == 0) {
+ return NetConstants.PATH_SEPARATOR_STR;
Review Comment:
In the javadoc you said `` If <i>path</i>is empty, then {@link NetConstants#ROOT} is returned`` but here you are returning ``return NetConstants.PATH_SEPARATOR_STR`` both have different values.
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NetUtils.java:
##########
@@ -149,4 +149,28 @@ public static List<Node> getAncestorList(NetworkTopology topology,
}
return ancestorList;
}
+
+ /**
+ * Ensure {@link NetConstants#PATH_SEPARATOR_STR} is added to the suffix of
+ * the path.
+ * @param path path to add suffix
+ * @return the normalised path
+ * If <i>path</i>is empty, then {@link NetConstants#ROOT} is returned
+ */
+ public static String addSuffix(String path) {
+ if (path == null) {
+ return null;
+ }
+
+ int len = path.length();
+ if (len == 0) {
+ return NetConstants.PATH_SEPARATOR_STR;
+ }
+
+ if (path.charAt(len - 1) != NetConstants.PATH_SEPARATOR) {
+ return path + NetConstants.PATH_SEPARATOR_STR;
+ }
+
+ return path;
Review Comment:
```suggestion
if (!path.endsWith(NetConstants.PATH_SEPARATOR_STR)) {
return path + NetConstants.PATH_SEPARATOR_STR;
}
```
Does this do the same thing?
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NetUtils.java:
##########
@@ -149,4 +149,28 @@ public static List<Node> getAncestorList(NetworkTopology topology,
}
return ancestorList;
}
+
+ /**
+ * Ensure {@link NetConstants#PATH_SEPARATOR_STR} is added to the suffix of
+ * the path.
+ * @param path path to add suffix
+ * @return the normalised path
+ * If <i>path</i>is empty, then {@link NetConstants#ROOT} is returned
+ */
+ public static String addSuffix(String path) {
+ if (path == null) {
+ return null;
+ }
Review Comment:
Why are you returning ``null`` here? Won't this lead to NPE in the isDecendent(String ..) & isAncesstor(String ..) methods.
For the same methods with argument as Node, if node is ``null``, you return false, but for the methods with argument as string you would return NPE, if the path is ``null``
Just FYI. In normalize method, it returns root in case of ``null``
```
public static String normalize(String path) {
if (path == null) {
return NetConstants.ROOT;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
symious commented on PR #3342:
URL: https://github.com/apache/ozone/pull/3342#issuecomment-1108029509
@adoroszlai @ChenSammi Could you help to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #3342: HDDS-6640. Node.isAncestor might return incorrect result
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on PR #3342:
URL: https://github.com/apache/ozone/pull/3342#issuecomment-1110513010
@symious , some comments about the naming. Besides that, the overall patch LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org