You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/27 13:32:38 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request #783: Add a test grouping on null (showing incorrect answers)
alamb opened a new pull request #783:
URL: https://github.com/apache/arrow-datafusion/pull/783
# Which issue does this PR close?
Re https://github.com/apache/arrow-datafusion/issues/782
# Rationale for this change
I wrote this test while working on another issue and I felt it was good coverage to add. I can be convinced it is not a good idea, however
# What changes are included in this PR?
A test (with incorrect answers) showing https://github.com/apache/arrow-datafusion/issues/782
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed pull request #783: Add a test grouping on null (showing incorrect answers)
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #783:
URL: https://github.com/apache/arrow-datafusion/pull/783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #783: Add a test grouping on null (showing incorrect answers)
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #783:
URL: https://github.com/apache/arrow-datafusion/pull/783#discussion_r677816816
##########
File path: datafusion/tests/sql.rs
##########
@@ -2966,6 +2966,45 @@ async fn query_count_distinct() -> Result<()> {
Ok(())
}
+#[tokio::test]
Review comment:
yeah, maybe that would be better...
If I am able to fix the problem in the next few days perhaps I can just incorporate this change into the proper fix 😆
I'll leave this PR as a draft for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #783: Add a test grouping on null (showing incorrect answers)
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #783:
URL: https://github.com/apache/arrow-datafusion/pull/783#issuecomment-889339885
superceded by https://github.com/apache/arrow-datafusion/pull/793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #783: Add a test grouping on null (showing incorrect answers)
Posted by GitBox <gi...@apache.org>.
Dandandan commented on a change in pull request #783:
URL: https://github.com/apache/arrow-datafusion/pull/783#discussion_r677660118
##########
File path: datafusion/tests/sql.rs
##########
@@ -2966,6 +2966,45 @@ async fn query_count_distinct() -> Result<()> {
Ok(())
}
+#[tokio::test]
Review comment:
We can also add it, but ignore the test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org