You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Dan Hecht (Code Review)" <ge...@cloudera.org> on 2017/10/04 17:30:01 UTC
[Impala-ASF-CR] Remove dead code parallel-executor*
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8206
Change subject: Remove dead code parallel-executor*
......................................................................
Remove dead code parallel-executor*
Change-Id: I7f0b121c2c40849937afa103dfedf0e0bef34477
---
M be/src/runtime/CMakeLists.txt
D be/src/runtime/parallel-executor-test.cc
D be/src/runtime/parallel-executor.cc
D be/src/runtime/parallel-executor.h
4 files changed, 0 insertions(+), 217 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/8206/1
--
To view, visit http://gerrit.cloudera.org:8080/8206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f0b121c2c40849937afa103dfedf0e0bef34477
Gerrit-Change-Number: 8206
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
[Impala-ASF-CR] IMPALA-6019: Remove dead code parallel-executor*
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8206 )
Change subject: IMPALA-6019: Remove dead code parallel-executor*
......................................................................
IMPALA-6019: Remove dead code parallel-executor*
Change-Id: I7f0b121c2c40849937afa103dfedf0e0bef34477
Reviewed-on: http://gerrit.cloudera.org:8080/8206
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/runtime/CMakeLists.txt
D be/src/runtime/parallel-executor-test.cc
D be/src/runtime/parallel-executor.cc
D be/src/runtime/parallel-executor.h
4 files changed, 0 insertions(+), 217 deletions(-)
Approvals:
Dan Hecht: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f0b121c2c40849937afa103dfedf0e0bef34477
Gerrit-Change-Number: 8206
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-6019: Remove dead code parallel-executor*
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8206 )
Change subject: IMPALA-6019: Remove dead code parallel-executor*
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1312/
--
To view, visit http://gerrit.cloudera.org:8080/8206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0b121c2c40849937afa103dfedf0e0bef34477
Gerrit-Change-Number: 8206
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2017 22:59:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6019: Remove dead code parallel-executor*
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8206 )
Change subject: IMPALA-6019: Remove dead code parallel-executor*
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0b121c2c40849937afa103dfedf0e0bef34477
Gerrit-Change-Number: 8206
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Oct 2017 03:02:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6019: Remove dead code parallel-executor*
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8206 )
Change subject: IMPALA-6019: Remove dead code parallel-executor*
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8206/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8206/1//COMMIT_MSG@7
PS1, Line 7: Remove dead code parallel-executor*
> Track it with a JIRA?
Done, though not sure it's really helpful to do so for this change.
--
To view, visit http://gerrit.cloudera.org:8080/8206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0b121c2c40849937afa103dfedf0e0bef34477
Gerrit-Change-Number: 8206
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2017 22:58:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Remove dead code parallel-executor*
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8206 )
Change subject: Remove dead code parallel-executor*
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8206/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8206/1//COMMIT_MSG@7
PS1, Line 7: Remove dead code parallel-executor*
Track it with a JIRA?
--
To view, visit http://gerrit.cloudera.org:8080/8206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0b121c2c40849937afa103dfedf0e0bef34477
Gerrit-Change-Number: 8206
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Oct 2017 22:37:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6019: Remove dead code parallel-executor*
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8206
to look at the new patch set (#2).
Change subject: IMPALA-6019: Remove dead code parallel-executor*
......................................................................
IMPALA-6019: Remove dead code parallel-executor*
Change-Id: I7f0b121c2c40849937afa103dfedf0e0bef34477
---
M be/src/runtime/CMakeLists.txt
D be/src/runtime/parallel-executor-test.cc
D be/src/runtime/parallel-executor.cc
D be/src/runtime/parallel-executor.h
4 files changed, 0 insertions(+), 217 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/8206/2
--
To view, visit http://gerrit.cloudera.org:8080/8206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f0b121c2c40849937afa103dfedf0e0bef34477
Gerrit-Change-Number: 8206
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-6019: Remove dead code parallel-executor*
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8206 )
Change subject: IMPALA-6019: Remove dead code parallel-executor*
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0b121c2c40849937afa103dfedf0e0bef34477
Gerrit-Change-Number: 8206
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2017 22:59:33 +0000
Gerrit-HasComments: No