You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by chandnisingh <gi...@git.apache.org> on 2016/02/20 01:45:16 UTC

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-1859 tracking viola...

GitHub user chandnisingh opened a pull request:

    https://github.com/apache/incubator-apex-malhar/pull/190

    APEXMALHAR-1859 tracking violation per malhar module

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chandnisingh/incubator-apex-malhar APEXMALHAR-1859

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-apex-malhar/pull/190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #190
    
----
commit 0ba6d03f275e1a3d860db0bd7cf2363bc01e0f70
Author: Chandni Singh <cs...@apache.org>
Date:   2016-02-20T00:44:02Z

    APEXMALHAR-1859 tracking violation per malhar module

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-1859 tracking viola...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-apex-malhar/pull/190


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-1859 tracking viola...

Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/190#discussion_r53539499
  
    --- Diff: pom.xml ---
    @@ -90,13 +90,6 @@
               </excludes>
             </configuration>
           </plugin>
    -      <plugin>
    --- End diff --
    
    Does this mean checkstyle is turned off by default? Wouldn't it be better to have it default to no violations with console output?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---