You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/02/20 18:55:00 UTC

[jira] [Commented] (TINKERPOP-2165) Prefer commons-lang3 to commons-lang

    [ https://issues.apache.org/jira/browse/TINKERPOP-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773278#comment-16773278 ] 

ASF GitHub Bot commented on TINKERPOP-2165:
-------------------------------------------

spmallette commented on pull request #1068: TINKERPOP-2165 Preferred commons-lang3 to commons-lang
URL: https://github.com/apache/tinkerpop/pull/1068
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-2165
   
   `commons-lang` is still part of TinkerPop because of `commons-configuration` and Spark, but at least our internally used code doesn't have to be dependent on it. Hopefully we can utterly remove that unmaintained line at some point in the future. NOTICE no longer needs the `commons-lang3` snippet as that aspect of their NOTICE has been removed in newer versions. 
   
   Made a light attempt to at trying to upgrade to `commons-configuration2` and deprecate out the older dependency but it was a bit messy and probably more trouble than it is worth along the 3.3.x line. Perhaps we look at that one later. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Prefer commons-lang3 to commons-lang
> ------------------------------------
>
>                 Key: TINKERPOP-2165
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2165
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: build-release
>    Affects Versions: 3.3.5
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Minor
>
> The {{commons-lang}} dependency is for 2.x and its last release goes back to 2011. I think our code references some of its classes, mostly because the IDE defaulted it that way on auto-import. Unfortunately, we can't lift it out completely without bumping {{commons-configuration}} which still depends on 2.x and that can't be done without a breaking change. I imagine we should consider that for TinkerPop 3.5.x and deprecate the use of that module in favor of the new Configuration 2.x, but I think that's for a different day. Looked into it a bit and it was a small mess.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)