You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/06/03 03:08:59 UTC
[GitHub] [hudi] hddong opened a new pull request #1699: [HUDI-989]Support long options for prepare_integration_suite
hddong opened a new pull request #1699:
URL: https://github.com/apache/hudi/pull/1699
## What is the purpose of the pull request
*Support long options for prepare_integration_suite.sh*
## Brief change log
- *Support long options for prepare_integration_suite.sh*
## Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
## Committer checklist
- [x] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hddong commented on pull request #1699: [HUDI-989]Support long options for prepare_integration_suite
Posted by GitBox <gi...@apache.org>.
hddong commented on pull request #1699:
URL: https://github.com/apache/hudi/pull/1699#issuecomment-640312814
@yanghua @n3nash please have a reivew when free.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter edited a comment on pull request #1699: [HUDI-989]Support long options for prepare_integration_suite
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1699:
URL: https://github.com/apache/hudi/pull/1699#issuecomment-638613017
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=h1) Report
> Merging [#1699](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=desc) into [hudi_test_suite_refactor](https://codecov.io/gh/apache/hudi/commit/6a0f4191ac34fc393d72f36530c8573273d4d045&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/1699/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## hudi_test_suite_refactor #1699 +/- ##
==============================================================
- Coverage 18.23% 18.21% -0.02%
+ Complexity 857 856 -1
==============================================================
Files 348 348
Lines 15346 15346
Branches 1524 1524
==============================================================
- Hits 2798 2796 -2
- Misses 12191 12193 +2
Partials 357 357
```
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/hudi/pull/1699/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | `21.98% <0.00%> (-0.71%)` | `28.00% <0.00%> (-1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=footer). Last update [6a0f419...3340a10](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua merged pull request #1699: [HUDI-989]Support long options for prepare_integration_suite
Posted by GitBox <gi...@apache.org>.
yanghua merged pull request #1699:
URL: https://github.com/apache/hudi/pull/1699
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter commented on pull request #1699: [HUDI-989]Support long options for prepare_integration_suite
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1699:
URL: https://github.com/apache/hudi/pull/1699#issuecomment-638613017
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=h1) Report
> Merging [#1699](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=desc) into [hudi_test_suite_refactor](https://codecov.io/gh/apache/hudi/commit/6a0f4191ac34fc393d72f36530c8573273d4d045&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/1699/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## hudi_test_suite_refactor #1699 +/- ##
==============================================================
- Coverage 18.23% 18.21% -0.02%
+ Complexity 857 856 -1
==============================================================
Files 348 348
Lines 15346 15346
Branches 1524 1524
==============================================================
- Hits 2798 2796 -2
- Misses 12191 12193 +2
Partials 357 357
```
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/hudi/pull/1699/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | `21.98% <0.00%> (-0.71%)` | `28.00% <0.00%> (-1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=footer). Last update [6a0f419...3340a10](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter edited a comment on pull request #1699: [HUDI-989]Support long options for prepare_integration_suite
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1699:
URL: https://github.com/apache/hudi/pull/1699#issuecomment-638613017
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=h1) Report
> Merging [#1699](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=desc) into [hudi_test_suite_refactor](https://codecov.io/gh/apache/hudi/commit/6a0f4191ac34fc393d72f36530c8573273d4d045&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/1699/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## hudi_test_suite_refactor #1699 +/- ##
==============================================================
- Coverage 18.23% 18.21% -0.02%
+ Complexity 857 856 -1
==============================================================
Files 348 348
Lines 15346 15346
Branches 1524 1524
==============================================================
- Hits 2798 2796 -2
- Misses 12191 12193 +2
Partials 357 357
```
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/hudi/pull/1699/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | `21.98% <0.00%> (-0.71%)` | `28.00% <0.00%> (-1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=footer). Last update [6a0f419...3340a10](https://codecov.io/gh/apache/hudi/pull/1699?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org