You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/01 16:12:02 UTC

[GitHub] [arrow] domoritz opened a new pull request #12773: ARROW-16098: [JS] Remove null from iterators

domoritz opened a new pull request #12773:
URL: https://github.com/apache/arrow/pull/12773


   Before Arrow 7, Table supported `Iterable<Record<string, any>>` and with this change it does support it again. 
   
   I wanted this to work:
   
   ```ts
   function foo(): Iterable<Record<string, any>> {
       return new Table();
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot commented on pull request #12773: ARROW-16098: [JS] Don't return null in table and recordbatch iterators

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12773:
URL: https://github.com/apache/arrow/pull/12773#issuecomment-1086742698


   Benchmark runs are scheduled for baseline = 8446109265e817e27fe4d88817d465a408410278 and contender = 33cb5bd919b8988a8292674651518e6c3edc9823. 33cb5bd919b8988a8292674651518e6c3edc9823 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ea4928948e724acb9daf661107368ec9...2b41e995f04c4926855d33d0e9730283/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/11ab1444535f4b1db23948710e9eccf7...748bf40a9b624edebe5f92ed1dc62c43/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9305f27588cc4272ba05e463940955d9...3e7172d2a4ba416c815fb6704676b279/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/30e38af2a258462e8a10140e49da1d12...cb5cb20c782e49c99d4f2814485de9e8/)
   Buildkite builds:
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/433| `33cb5bd9` ec2-t3-xlarge-us-east-2>
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/418| `33cb5bd9` test-mac-arm>
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/428| `33cb5bd9` ursa-thinkcentre-m75q>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/432| `84461092` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/417| `84461092` test-mac-arm>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/427| `84461092` ursa-thinkcentre-m75q>
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #12773: ARROW-16098: [JS] Don't return null in table and recordbatch iterators

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12773:
URL: https://github.com/apache/arrow/pull/12773#issuecomment-1086167753






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12773: ARROW-16098: [JS] Don't return null in table and recordbatch iterators

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12773:
URL: https://github.com/apache/arrow/pull/12773#issuecomment-1086742698


   Benchmark runs are scheduled for baseline = 8446109265e817e27fe4d88817d465a408410278 and contender = 33cb5bd919b8988a8292674651518e6c3edc9823. 33cb5bd919b8988a8292674651518e6c3edc9823 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ea4928948e724acb9daf661107368ec9...2b41e995f04c4926855d33d0e9730283/)
   [Failed :arrow_down:0.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/11ab1444535f4b1db23948710e9eccf7...748bf40a9b624edebe5f92ed1dc62c43/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9305f27588cc4272ba05e463940955d9...3e7172d2a4ba416c815fb6704676b279/)
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/30e38af2a258462e8a10140e49da1d12...cb5cb20c782e49c99d4f2814485de9e8/)
   Buildkite builds:
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/433| `33cb5bd9` ec2-t3-xlarge-us-east-2>
   [Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/418| `33cb5bd9` test-mac-arm>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/428| `33cb5bd9` ursa-thinkcentre-m75q>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/432| `84461092` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/417| `84461092` test-mac-arm>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/427| `84461092` ursa-thinkcentre-m75q>
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] domoritz closed pull request #12773: ARROW-16098: [JS] Don't return null in table and recordbatch iterators

Posted by GitBox <gi...@apache.org>.
domoritz closed pull request #12773:
URL: https://github.com/apache/arrow/pull/12773


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12773: ARROW-16098: [JS] Don't return null in table and recordbatch iterators

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12773:
URL: https://github.com/apache/arrow/pull/12773#issuecomment-1086742698


   Benchmark runs are scheduled for baseline = 8446109265e817e27fe4d88817d465a408410278 and contender = 33cb5bd919b8988a8292674651518e6c3edc9823. 33cb5bd919b8988a8292674651518e6c3edc9823 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ea4928948e724acb9daf661107368ec9...2b41e995f04c4926855d33d0e9730283/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/11ab1444535f4b1db23948710e9eccf7...748bf40a9b624edebe5f92ed1dc62c43/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9305f27588cc4272ba05e463940955d9...3e7172d2a4ba416c815fb6704676b279/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/30e38af2a258462e8a10140e49da1d12...cb5cb20c782e49c99d4f2814485de9e8/)
   Buildkite builds:
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/433| `33cb5bd9` ec2-t3-xlarge-us-east-2>
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/418| `33cb5bd9` test-mac-arm>
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/428| `33cb5bd9` ursa-thinkcentre-m75q>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/432| `84461092` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/417| `84461092` test-mac-arm>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/427| `84461092` ursa-thinkcentre-m75q>
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12773: ARROW-16098: [JS] Don't return null in table and recordbatch iterators

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12773:
URL: https://github.com/apache/arrow/pull/12773#issuecomment-1086742698


   Benchmark runs are scheduled for baseline = 8446109265e817e27fe4d88817d465a408410278 and contender = 33cb5bd919b8988a8292674651518e6c3edc9823. 33cb5bd919b8988a8292674651518e6c3edc9823 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ea4928948e724acb9daf661107368ec9...2b41e995f04c4926855d33d0e9730283/)
   [Failed :arrow_down:0.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/11ab1444535f4b1db23948710e9eccf7...748bf40a9b624edebe5f92ed1dc62c43/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9305f27588cc4272ba05e463940955d9...3e7172d2a4ba416c815fb6704676b279/)
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/30e38af2a258462e8a10140e49da1d12...cb5cb20c782e49c99d4f2814485de9e8/)
   Buildkite builds:
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/433| `33cb5bd9` ec2-t3-xlarge-us-east-2>
   [Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/418| `33cb5bd9` test-mac-arm>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/428| `33cb5bd9` ursa-thinkcentre-m75q>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/432| `84461092` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/417| `84461092` test-mac-arm>
   [Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/417| `84461092` ursa-i9-9960x>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/427| `84461092` ursa-thinkcentre-m75q>
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org