You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Charles Reiss <wo...@gmail.com> on 2011/11/01 21:02:33 UTC

Review Request: Use $(SRCDIR) more in JAR build rule.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2661/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Summary
-------

The MESOS-49 patch broke out of source builds (if the Java API is built) because it didn't use $(SRCDIR) in a couple places.


Diffs
-----

  src/Makefile.in e3ae6f8 

Diff: https://reviews.apache.org/r/2661/diff


Testing
-------


Thanks,

Charles


Re: Review Request: Use $(SRCDIR) more in JAR build rule.

Posted by Andy Konwinski <an...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2661/#review3061
-----------------------------------------------------------

Ship it!


This patch looks great. Thanks Charles!

- Andy


On 2011-11-01 20:02:33, Charles Reiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2661/
> -----------------------------------------------------------
> 
> (Updated 2011-11-01 20:02:33)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Summary
> -------
> 
> The MESOS-49 patch broke out of source builds (if the Java API is built) because it didn't use $(SRCDIR) in a couple places.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.in e3ae6f8 
> 
> Diff: https://reviews.apache.org/r/2661/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Charles
> 
>