[GitHub] shiro pull request #32: WIP: Attempt at getting guice 3 and 4 both supported

[bdemers <gi...@git.apache.org>]

GitHub user bdemers opened a pull request:

    https://github.com/apache/shiro/pull/32

    WIP: Attempt at getting guice 3 and 4 both supported

    This still needs some cleaning up, but I was hacking on this last night, and I _think_ this will work.
    It needs a few eyes, and I have a couple questions, that I'll annotate here.
    
    This does not have separate test module like #26 (to enable guice4 you can just use the profile `guice4`, I don't like this, but it works for hacking around). We should add a test module like #26, or something similar.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bdemers/shiro new-guice

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/shiro/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #32
    
----
commit 525fa39acc9f730c443b15e8a06af7fb6f233b41
Author: Brian Demers <bd...@apache.org>
Date:   2016-07-14T13:51:45Z

    Attempt at getting guice 3 and 4 both supported

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---