[jira] [Commented] (ISIS-1991) Determining the deployment type is broken

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ISIS-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662822#comment-16662822 ] 

ASF subversion and git services commented on ISIS-1991:
-------------------------------------------------------

Commit e3e3c48667b5c77f75c0a763c154bb027b7a47e7 in isis's branch refs/heads/v2 from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=e3e3c48 ]

ISIS-1991: allows for the Isis system environment to be primed from
config values

that is "isis.deploymentType=SERVER" or
"isis.deploymentType=SERVER_PROTOTYPE"

to prime the system environment one can use
IsisContext.primeEnvironment(IsisConfiguration conf)


> Determining the deployment type is broken
> -----------------------------------------
>
>                 Key: ISIS-1991
>                 URL: https://issues.apache.org/jira/browse/ISIS-1991
>             Project: Isis
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M1
>            Reporter: Andi Huber
>            Assignee: Andi Huber
>            Priority: Major
>             Fix For: 2.0.0-M2
>
>
> We seem to have multiple classes within 'core' that act as advisors for determining the application's deployment-type.
> Maybe we need to rethink and cleanup. I think it should be sufficient to have one and only one place to configure the deployment type. eg. simply via a single environment variable.
> To pick up this idea [1], we could introduce one layer of abstraction. Also note: We need to have access to this variable very early in the bootstrapping phase.
> [1] https://stackoverflow.com/questions/8168884/how-to-test-code-dependent-on-environment-variables-using-junit



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)