You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/09/12 14:52:18 UTC
[GitHub] [skywalking-rocketbot-ui] Jtrust opened a new pull request #354: Implement browser metrics in dashboard
Jtrust opened a new pull request #354:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/354
- [x] New feature provided
Implement browser metrics in dashboard [#5228](https://github.com/apache/skywalking/issues/5228)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #354: Feat: Implement browser metrics in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #354:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/354#issuecomment-705349836
@Jtrust From the screenshot, the comments are following,
1. error info and stack should support multiple lines and width changable.
1. The order of columns should be `time`, `service`, `error`, `stack`, `version`, `url`, `catalog`, and `grade`.
1. The column separator breaks.
1. We should be clear, what is `line` and `col` for, @Fine0830
1. Every char of the words in the title should be upper case, take a look at the trace table view page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #354: Feat: Implement browser metrics in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #354:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/354#issuecomment-711797089
Please fix the log page error later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng merged pull request #354: Feat: Implement browser metrics in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #354:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/354
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #354: Feat: Implement browser metrics in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #354:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/354#issuecomment-705355110
> We should be clear, what is line and col for
The line and column should be targeting `url`, so, should have a part of URL, `/index.html (line, xxx. column, yyy)` @Fine0830 Does this make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #354: Implement browser metrics in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #354:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/354#issuecomment-691503714
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Jtrust commented on pull request #354: Feat: Implement browser metrics in dashboard
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #354:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/354#issuecomment-705260507
<img width="1428" alt="WX20201008-081339@2x" src="https://user-images.githubusercontent.com/21056967/95401133-0667fd00-093f-11eb-99f0-6913cdf8e074.png">
screenshots
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #354: Implement browser metrics in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #354:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/354#issuecomment-691503714
Logs query should move into another top tab.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #354: Implement browser metrics in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #354:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/354#issuecomment-691503714
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #354: Feat: Implement browser metrics in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #354:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/354#issuecomment-705349836
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Jtrust commented on pull request #354: Implement browser metrics in dashboard
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #354:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/354#issuecomment-691502111
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Jtrust commented on pull request #354: Implement browser metrics in dashboard
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #354:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/354#issuecomment-691502111
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Jtrust commented on pull request #354: Implement browser metrics in dashboard
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #354:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/354#issuecomment-691502111
<img width="1663" alt="WX20200912-225311@2x" src="https://user-images.githubusercontent.com/21056967/92998156-d5b4c380-f54a-11ea-9ef9-f171415d89d3.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org