[GitHub] [iceberg] dimas-b commented on a diff in pull request #5312: Build: Enforce spotless & spotlessApply

[GitBox <gi...@apache.org>]

dimas-b commented on code in PR #5312:
URL: https://github.com/apache/iceberg/pull/5312#discussion_r925642153


##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -495,7 +437,6 @@
             <property name="allowOneCharVarInForLoop" value="true"/>
             <message key="name.invalidPattern" value="Local variable name ''{0}'' must match pattern ''{1}''."/>
         </module>
-        <module name="MethodLength"/> <!-- Java Coding Guide: Methods and functions: focused, crisp, concise -->

Review Comment:
   I guess this goes beyond the google style... Do we want to keep this rule?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org