You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/02/17 16:33:12 UTC
Review Request 31116: LENS-311 : Packaging and README update for
source and binary distribution
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31116/
-----------------------------------------------------------
Review request for lens, Chris Douglas and Srikanth Sundarrajan.
Bugs: LENS-311
https://issues.apache.org/jira/browse/LENS-311
Repository: lens
Description
-------
Changes include :
- Change source release artifact name to include apache-lens. Changed lens-parent to apache-lens.
- Add exclusion for org.acplt:oncrpc in apache-release profile
- Add LICENSE and NOTICE in war packaging
- Update README.md for source distribution
- Update bin-dist-files/README for binary distribution
Have some questions :
- LICENSE and NOTICE in lens-server.war looks the following. Is this acceptable?
$ ls webapp/lens-server/
META-INF/ WEB-INF/ static/
$ ls webapp/lens-server/META-INF/
MANIFEST.MF maven/
$ ls webapp/lens-server/WEB-INF/
classes/ lib/ log4j.properties web.xml
$ ls webapp/lens-server/WEB-INF/classes/
META-INF/ lens-build-info.properties lensserver-default.xml lenssession-default.xml org/
$ ls webapp/lens-server/WEB-INF/classes/META-INF/
DEPENDENCIES LICENSE NOTICE
- Is it ok to have README file README.md for source distribution?
- bin-dist-files folder is included in src distribution. Is it acceptable?
Diffs
-----
README.md 07a3249
bin-dist-files/README 3e74fb9
lens-api/pom.xml b955c1a
lens-cli/pom.xml 26adc54
lens-client/pom.xml e56df03
lens-cube/pom.xml 274d1ea
lens-dist/pom.xml ddebf16
lens-driver-hive/pom.xml be0c1b7
lens-driver-jdbc/pom.xml daab50d
lens-examples/pom.xml 2163785
lens-ml-lib/pom.xml 3cdca92
lens-query-lib/pom.xml 95d9d93
lens-regression/pom.xml d506eaa
lens-server-api/pom.xml f490dee
lens-server/pom.xml 0986ab9
lens-storage-db/pom.xml fb35e12
pom.xml 38d1693
src/site/apt/lenshome/install-and-run.apt 6031cf9
src/site/apt/releases/release-history.apt f5f6139
Diff: https://reviews.apache.org/r/31116/diff/
Testing
-------
Verified packaging is fine by untarring the distribution. Will do some more testing and update here.
Thanks,
Amareshwari Sriramadasu
Re: Review Request 31116: LENS-311 : Packaging and README update for
source and binary distribution
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Feb. 17, 2015, 3:38 p.m., Srikanth Sundarrajan wrote:
> > bin-dist-files/README, line 57
> > <https://reviews.apache.org/r/31116/diff/1/?file=866324#file866324line57>
> >
> > I know we are also creating a deb file. Do we intend to make it available as a conveninent binary ? If so, we should have notes on how to setup using deb, else you can ignore.
> >
> > In general there needs to documentation on how deb can be used for installation, but that can be taken up in an independent jira and not a blocker for release.
Yes. Debians are not part of binary distribution as of now. There is mention of debians in http://lens.incubator.apache.org/developer/contribute.html#Building_from_source doc. We can put a separate section and add more details about.
> On Feb. 17, 2015, 3:38 p.m., Srikanth Sundarrajan wrote:
> > src/site/apt/releases/release-history.apt, line 29
> > <https://reviews.apache.org/r/31116/diff/1/?file=866341#file866341line29>
> >
> > Why is this in release history and not in README ? Should we state why it is excluded as well ?
Added the reason and put in README as well.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31116/#review72721
-----------------------------------------------------------
On Feb. 18, 2015, 5:25 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31116/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 5:25 a.m.)
>
>
> Review request for lens, Chris Douglas and Srikanth Sundarrajan.
>
>
> Bugs: LENS-311
> https://issues.apache.org/jira/browse/LENS-311
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Change source release artifact name to include apache-lens. Changed lens-parent to apache-lens.
> - Add exclusion for org.acplt:oncrpc in apache-release profile
> - Add LICENSE and NOTICE in war packaging
> - Update README.md for source distribution
> - Update bin-dist-files/README for binary distribution
>
> Have some questions :
> - LICENSE and NOTICE in lens-server.war looks the following. Is this acceptable?
> $ ls webapp/lens-server/
> META-INF/ WEB-INF/ static/
>
> $ ls webapp/lens-server/META-INF/
> MANIFEST.MF maven/
>
> $ ls webapp/lens-server/WEB-INF/
> classes/ lib/ log4j.properties web.xml
>
> $ ls webapp/lens-server/WEB-INF/classes/
> META-INF/ lens-build-info.properties lensserver-default.xml lenssession-default.xml org/
>
> $ ls webapp/lens-server/WEB-INF/classes/META-INF/
> DEPENDENCIES LICENSE NOTICE
>
> - Is it ok to have README file README.md for source distribution?
> - bin-dist-files folder is included in src distribution. Is it acceptable?
>
>
> Diffs
> -----
>
> README.md 07a3249
> bin-dist-files/README 3e74fb9
> lens-api/pom.xml b955c1a
> lens-cli/pom.xml 26adc54
> lens-client/pom.xml e56df03
> lens-cube/pom.xml 274d1ea
> lens-dist/pom.xml ddebf16
> lens-driver-hive/pom.xml be0c1b7
> lens-driver-jdbc/pom.xml daab50d
> lens-examples/pom.xml 2163785
> lens-ml-lib/pom.xml 3cdca92
> lens-query-lib/pom.xml 95d9d93
> lens-regression/pom.xml d506eaa
> lens-server-api/pom.xml f490dee
> lens-server/pom.xml 0986ab9
> lens-storage-db/pom.xml fb35e12
> pom.xml 38d1693
> src/site/apt/developer/contribute.apt 91e7b81
> src/site/apt/lenshome/install-and-run.apt 6031cf9
> src/site/apt/releases/release-history.apt f5f6139
>
> Diff: https://reviews.apache.org/r/31116/diff/
>
>
> Testing
> -------
>
> Verified packaging is fine by untarring the distribution. Will do some more testing and update here.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 31116: LENS-311 : Packaging and README update for
source and binary distribution
Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31116/#review72721
-----------------------------------------------------------
README.md
<https://reviews.apache.org/r/31116/#comment118776>
Typo
bin-dist-files/README
<https://reviews.apache.org/r/31116/#comment118777>
I know we are also creating a deb file. Do we intend to make it available as a conveninent binary ? If so, we should have notes on how to setup using deb, else you can ignore.
In general there needs to documentation on how deb can be used for installation, but that can be taken up in an independent jira and not a blocker for release.
src/site/apt/releases/release-history.apt
<https://reviews.apache.org/r/31116/#comment118778>
Why is this in release history and not in README ? Should we state why it is excluded as well ?
- Srikanth Sundarrajan
On Feb. 17, 2015, 3:33 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31116/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 3:33 p.m.)
>
>
> Review request for lens, Chris Douglas and Srikanth Sundarrajan.
>
>
> Bugs: LENS-311
> https://issues.apache.org/jira/browse/LENS-311
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Change source release artifact name to include apache-lens. Changed lens-parent to apache-lens.
> - Add exclusion for org.acplt:oncrpc in apache-release profile
> - Add LICENSE and NOTICE in war packaging
> - Update README.md for source distribution
> - Update bin-dist-files/README for binary distribution
>
> Have some questions :
> - LICENSE and NOTICE in lens-server.war looks the following. Is this acceptable?
> $ ls webapp/lens-server/
> META-INF/ WEB-INF/ static/
>
> $ ls webapp/lens-server/META-INF/
> MANIFEST.MF maven/
>
> $ ls webapp/lens-server/WEB-INF/
> classes/ lib/ log4j.properties web.xml
>
> $ ls webapp/lens-server/WEB-INF/classes/
> META-INF/ lens-build-info.properties lensserver-default.xml lenssession-default.xml org/
>
> $ ls webapp/lens-server/WEB-INF/classes/META-INF/
> DEPENDENCIES LICENSE NOTICE
>
> - Is it ok to have README file README.md for source distribution?
> - bin-dist-files folder is included in src distribution. Is it acceptable?
>
>
> Diffs
> -----
>
> README.md 07a3249
> bin-dist-files/README 3e74fb9
> lens-api/pom.xml b955c1a
> lens-cli/pom.xml 26adc54
> lens-client/pom.xml e56df03
> lens-cube/pom.xml 274d1ea
> lens-dist/pom.xml ddebf16
> lens-driver-hive/pom.xml be0c1b7
> lens-driver-jdbc/pom.xml daab50d
> lens-examples/pom.xml 2163785
> lens-ml-lib/pom.xml 3cdca92
> lens-query-lib/pom.xml 95d9d93
> lens-regression/pom.xml d506eaa
> lens-server-api/pom.xml f490dee
> lens-server/pom.xml 0986ab9
> lens-storage-db/pom.xml fb35e12
> pom.xml 38d1693
> src/site/apt/lenshome/install-and-run.apt 6031cf9
> src/site/apt/releases/release-history.apt f5f6139
>
> Diff: https://reviews.apache.org/r/31116/diff/
>
>
> Testing
> -------
>
> Verified packaging is fine by untarring the distribution. Will do some more testing and update here.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 31116: LENS-311 : Packaging and README update for
source and binary distribution
Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31116/#review72960
-----------------------------------------------------------
Ship it!
Ship It!
- Srikanth Sundarrajan
On Feb. 18, 2015, 9:32 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31116/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 9:32 a.m.)
>
>
> Review request for lens, Chris Douglas and Srikanth Sundarrajan.
>
>
> Bugs: LENS-311
> https://issues.apache.org/jira/browse/LENS-311
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Change source release artifact name to include apache-lens. Changed lens-parent to apache-lens.
> - Add exclusion for org.acplt:oncrpc in apache-release profile
> - Add LICENSE and NOTICE in war packaging
> - Update README.md for source distribution
> - Update bin-dist-files/README for binary distribution
>
> Have some questions :
> - LICENSE and NOTICE in lens-server.war looks the following. Is this acceptable?
> $ ls webapp/lens-server/
> META-INF/ WEB-INF/ static/
>
> $ ls webapp/lens-server/META-INF/
> MANIFEST.MF maven/
>
> $ ls webapp/lens-server/WEB-INF/
> classes/ lib/ log4j.properties web.xml
>
> $ ls webapp/lens-server/WEB-INF/classes/
> META-INF/ lens-build-info.properties lensserver-default.xml lenssession-default.xml org/
>
> $ ls webapp/lens-server/WEB-INF/classes/META-INF/
> DEPENDENCIES LICENSE NOTICE
>
> - Is it ok to have README file README.md for source distribution?
> - bin-dist-files folder is included in src distribution. Is it acceptable?
>
>
> Diffs
> -----
>
> README.md 07a3249
> bin-dist-files/README 3e74fb9
> lens-api/pom.xml b955c1a
> lens-cli/pom.xml 26adc54
> lens-client/pom.xml e56df03
> lens-cube/pom.xml 274d1ea
> lens-dist/pom.xml ddebf16
> lens-dist/src/deb/control/server-control/postinst 0cd9d57
> lens-dist/src/main/assembly/bin-dist.xml 4ec2d55
> lens-driver-hive/pom.xml be0c1b7
> lens-driver-jdbc/pom.xml daab50d
> lens-examples/pom.xml 2163785
> lens-ml-lib/pom.xml 3cdca92
> lens-query-lib/pom.xml 95d9d93
> lens-regression/pom.xml d506eaa
> lens-server-api/pom.xml f490dee
> lens-server/pom.xml 0986ab9
> lens-storage-db/pom.xml fb35e12
> pom.xml 38d1693
> src/site/apt/developer/contribute.apt 91e7b81
> src/site/apt/lenshome/install-and-run.apt 6031cf9
> src/site/apt/releases/release-history.apt f5f6139
> tools/scripts/lens-cli 66106c1
>
> Diff: https://reviews.apache.org/r/31116/diff/
>
>
> Testing
> -------
>
> Verified packaging is fine by untarring the distribution.
>
> Build from source tarball succeeds :
> unzip apache-lens-2.1.0-incubating-SNAPSHOT-source-release.zip
> mvn clean package passes
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [9.912s]
> [INFO] Lens .............................................. SUCCESS [7.799s]
> [INFO] Lens API .......................................... SUCCESS [16.536s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.950s]
> [INFO] Lens Cube ......................................... SUCCESS [11:37.343s]
> [INFO] Lens DB storage ................................... SUCCESS [41.636s]
> [INFO] Lens Query Library ................................ SUCCESS [9.480s]
> [INFO] Lens Hive Driver .................................. SUCCESS [5:43.076s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [1:02.941s]
> [INFO] Lens Server ....................................... SUCCESS [19:36.778s]
> [INFO] Lens client ....................................... SUCCESS [1:05.589s]
> [INFO] Lens CLI .......................................... SUCCESS [4:10.956s]
> [INFO] Lens Examples ..................................... SUCCESS [1.867s]
> [INFO] Lens Distribution ................................. SUCCESS [27.936s]
> [INFO] Lens ML Lib ....................................... SUCCESS [5:12.667s]
> [INFO] Lens Regression ................................... SUCCESS [0.944s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
> Ran examples from binary distribution.
>
> Installed debians, started server from deb installation and verified client through cli.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 31116: LENS-311 : Packaging and README update for
source and binary distribution
Posted by Chris Douglas <cd...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31116/#review73019
-----------------------------------------------------------
Ship it!
Ship It!
- Chris Douglas
On Feb. 18, 2015, 9:32 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31116/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 9:32 a.m.)
>
>
> Review request for lens, Chris Douglas and Srikanth Sundarrajan.
>
>
> Bugs: LENS-311
> https://issues.apache.org/jira/browse/LENS-311
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Change source release artifact name to include apache-lens. Changed lens-parent to apache-lens.
> - Add exclusion for org.acplt:oncrpc in apache-release profile
> - Add LICENSE and NOTICE in war packaging
> - Update README.md for source distribution
> - Update bin-dist-files/README for binary distribution
>
> Have some questions :
> - LICENSE and NOTICE in lens-server.war looks the following. Is this acceptable?
> $ ls webapp/lens-server/
> META-INF/ WEB-INF/ static/
>
> $ ls webapp/lens-server/META-INF/
> MANIFEST.MF maven/
>
> $ ls webapp/lens-server/WEB-INF/
> classes/ lib/ log4j.properties web.xml
>
> $ ls webapp/lens-server/WEB-INF/classes/
> META-INF/ lens-build-info.properties lensserver-default.xml lenssession-default.xml org/
>
> $ ls webapp/lens-server/WEB-INF/classes/META-INF/
> DEPENDENCIES LICENSE NOTICE
>
> - Is it ok to have README file README.md for source distribution?
> - bin-dist-files folder is included in src distribution. Is it acceptable?
>
>
> Diffs
> -----
>
> README.md 07a3249
> bin-dist-files/README 3e74fb9
> lens-api/pom.xml b955c1a
> lens-cli/pom.xml 26adc54
> lens-client/pom.xml e56df03
> lens-cube/pom.xml 274d1ea
> lens-dist/pom.xml ddebf16
> lens-dist/src/deb/control/server-control/postinst 0cd9d57
> lens-dist/src/main/assembly/bin-dist.xml 4ec2d55
> lens-driver-hive/pom.xml be0c1b7
> lens-driver-jdbc/pom.xml daab50d
> lens-examples/pom.xml 2163785
> lens-ml-lib/pom.xml 3cdca92
> lens-query-lib/pom.xml 95d9d93
> lens-regression/pom.xml d506eaa
> lens-server-api/pom.xml f490dee
> lens-server/pom.xml 0986ab9
> lens-storage-db/pom.xml fb35e12
> pom.xml 38d1693
> src/site/apt/developer/contribute.apt 91e7b81
> src/site/apt/lenshome/install-and-run.apt 6031cf9
> src/site/apt/releases/release-history.apt f5f6139
> tools/scripts/lens-cli 66106c1
>
> Diff: https://reviews.apache.org/r/31116/diff/
>
>
> Testing
> -------
>
> Verified packaging is fine by untarring the distribution.
>
> Build from source tarball succeeds :
> unzip apache-lens-2.1.0-incubating-SNAPSHOT-source-release.zip
> mvn clean package passes
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [9.912s]
> [INFO] Lens .............................................. SUCCESS [7.799s]
> [INFO] Lens API .......................................... SUCCESS [16.536s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.950s]
> [INFO] Lens Cube ......................................... SUCCESS [11:37.343s]
> [INFO] Lens DB storage ................................... SUCCESS [41.636s]
> [INFO] Lens Query Library ................................ SUCCESS [9.480s]
> [INFO] Lens Hive Driver .................................. SUCCESS [5:43.076s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [1:02.941s]
> [INFO] Lens Server ....................................... SUCCESS [19:36.778s]
> [INFO] Lens client ....................................... SUCCESS [1:05.589s]
> [INFO] Lens CLI .......................................... SUCCESS [4:10.956s]
> [INFO] Lens Examples ..................................... SUCCESS [1.867s]
> [INFO] Lens Distribution ................................. SUCCESS [27.936s]
> [INFO] Lens ML Lib ....................................... SUCCESS [5:12.667s]
> [INFO] Lens Regression ................................... SUCCESS [0.944s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
> Ran examples from binary distribution.
>
> Installed debians, started server from deb installation and verified client through cli.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 31116: LENS-311 : Packaging and README update for
source and binary distribution
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31116/
-----------------------------------------------------------
(Updated Feb. 18, 2015, 9:32 a.m.)
Review request for lens, Chris Douglas and Srikanth Sundarrajan.
Bugs: LENS-311
https://issues.apache.org/jira/browse/LENS-311
Repository: lens
Description
-------
Changes include :
- Change source release artifact name to include apache-lens. Changed lens-parent to apache-lens.
- Add exclusion for org.acplt:oncrpc in apache-release profile
- Add LICENSE and NOTICE in war packaging
- Update README.md for source distribution
- Update bin-dist-files/README for binary distribution
Have some questions :
- LICENSE and NOTICE in lens-server.war looks the following. Is this acceptable?
$ ls webapp/lens-server/
META-INF/ WEB-INF/ static/
$ ls webapp/lens-server/META-INF/
MANIFEST.MF maven/
$ ls webapp/lens-server/WEB-INF/
classes/ lib/ log4j.properties web.xml
$ ls webapp/lens-server/WEB-INF/classes/
META-INF/ lens-build-info.properties lensserver-default.xml lenssession-default.xml org/
$ ls webapp/lens-server/WEB-INF/classes/META-INF/
DEPENDENCIES LICENSE NOTICE
- Is it ok to have README file README.md for source distribution?
- bin-dist-files folder is included in src distribution. Is it acceptable?
Diffs
-----
README.md 07a3249
bin-dist-files/README 3e74fb9
lens-api/pom.xml b955c1a
lens-cli/pom.xml 26adc54
lens-client/pom.xml e56df03
lens-cube/pom.xml 274d1ea
lens-dist/pom.xml ddebf16
lens-dist/src/deb/control/server-control/postinst 0cd9d57
lens-dist/src/main/assembly/bin-dist.xml 4ec2d55
lens-driver-hive/pom.xml be0c1b7
lens-driver-jdbc/pom.xml daab50d
lens-examples/pom.xml 2163785
lens-ml-lib/pom.xml 3cdca92
lens-query-lib/pom.xml 95d9d93
lens-regression/pom.xml d506eaa
lens-server-api/pom.xml f490dee
lens-server/pom.xml 0986ab9
lens-storage-db/pom.xml fb35e12
pom.xml 38d1693
src/site/apt/developer/contribute.apt 91e7b81
src/site/apt/lenshome/install-and-run.apt 6031cf9
src/site/apt/releases/release-history.apt f5f6139
tools/scripts/lens-cli 66106c1
Diff: https://reviews.apache.org/r/31116/diff/
Testing (updated)
-------
Verified packaging is fine by untarring the distribution.
Build from source tarball succeeds :
unzip apache-lens-2.1.0-incubating-SNAPSHOT-source-release.zip
mvn clean package passes
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [9.912s]
[INFO] Lens .............................................. SUCCESS [7.799s]
[INFO] Lens API .......................................... SUCCESS [16.536s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.950s]
[INFO] Lens Cube ......................................... SUCCESS [11:37.343s]
[INFO] Lens DB storage ................................... SUCCESS [41.636s]
[INFO] Lens Query Library ................................ SUCCESS [9.480s]
[INFO] Lens Hive Driver .................................. SUCCESS [5:43.076s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [1:02.941s]
[INFO] Lens Server ....................................... SUCCESS [19:36.778s]
[INFO] Lens client ....................................... SUCCESS [1:05.589s]
[INFO] Lens CLI .......................................... SUCCESS [4:10.956s]
[INFO] Lens Examples ..................................... SUCCESS [1.867s]
[INFO] Lens Distribution ................................. SUCCESS [27.936s]
[INFO] Lens ML Lib ....................................... SUCCESS [5:12.667s]
[INFO] Lens Regression ................................... SUCCESS [0.944s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Ran examples from binary distribution.
Installed debians, started server from deb installation and verified client through cli.
Thanks,
Amareshwari Sriramadasu
Re: Review Request 31116: LENS-311 : Packaging and README update for
source and binary distribution
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31116/
-----------------------------------------------------------
(Updated Feb. 18, 2015, 8:35 a.m.)
Review request for lens, Chris Douglas and Srikanth Sundarrajan.
Changes
-------
Fixed debian issues.
Named untarred binary distribution to contain -bin in the name. Otherwise both source and binary were getting unzipped/untarred into same directory.
Bugs: LENS-311
https://issues.apache.org/jira/browse/LENS-311
Repository: lens
Description
-------
Changes include :
- Change source release artifact name to include apache-lens. Changed lens-parent to apache-lens.
- Add exclusion for org.acplt:oncrpc in apache-release profile
- Add LICENSE and NOTICE in war packaging
- Update README.md for source distribution
- Update bin-dist-files/README for binary distribution
Have some questions :
- LICENSE and NOTICE in lens-server.war looks the following. Is this acceptable?
$ ls webapp/lens-server/
META-INF/ WEB-INF/ static/
$ ls webapp/lens-server/META-INF/
MANIFEST.MF maven/
$ ls webapp/lens-server/WEB-INF/
classes/ lib/ log4j.properties web.xml
$ ls webapp/lens-server/WEB-INF/classes/
META-INF/ lens-build-info.properties lensserver-default.xml lenssession-default.xml org/
$ ls webapp/lens-server/WEB-INF/classes/META-INF/
DEPENDENCIES LICENSE NOTICE
- Is it ok to have README file README.md for source distribution?
- bin-dist-files folder is included in src distribution. Is it acceptable?
Diffs (updated)
-----
README.md 07a3249
bin-dist-files/README 3e74fb9
lens-api/pom.xml b955c1a
lens-cli/pom.xml 26adc54
lens-client/pom.xml e56df03
lens-cube/pom.xml 274d1ea
lens-dist/pom.xml ddebf16
lens-dist/src/deb/control/server-control/postinst 0cd9d57
lens-dist/src/main/assembly/bin-dist.xml 4ec2d55
lens-driver-hive/pom.xml be0c1b7
lens-driver-jdbc/pom.xml daab50d
lens-examples/pom.xml 2163785
lens-ml-lib/pom.xml 3cdca92
lens-query-lib/pom.xml 95d9d93
lens-regression/pom.xml d506eaa
lens-server-api/pom.xml f490dee
lens-server/pom.xml 0986ab9
lens-storage-db/pom.xml fb35e12
pom.xml 38d1693
src/site/apt/developer/contribute.apt 91e7b81
src/site/apt/lenshome/install-and-run.apt 6031cf9
src/site/apt/releases/release-history.apt f5f6139
tools/scripts/lens-cli 66106c1
Diff: https://reviews.apache.org/r/31116/diff/
Testing (updated)
-------
Verified packaging is fine by untarring the distribution.
Build from source tarball succeeds :
unzip apache-lens-2.1.0-incubating-SNAPSHOT-source-release.zip
mvn clean package -DskipTests.
Running all tests. Will update once done
Ran examples from binary distribution.
Installed debians, started server from deb installation and verified client through cli.
Thanks,
Amareshwari Sriramadasu
Re: Review Request 31116: LENS-311 : Packaging and README update for
source and binary distribution
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31116/
-----------------------------------------------------------
(Updated Feb. 18, 2015, 5:25 a.m.)
Review request for lens, Chris Douglas and Srikanth Sundarrajan.
Changes
-------
Review comments fixed
Bugs: LENS-311
https://issues.apache.org/jira/browse/LENS-311
Repository: lens
Description
-------
Changes include :
- Change source release artifact name to include apache-lens. Changed lens-parent to apache-lens.
- Add exclusion for org.acplt:oncrpc in apache-release profile
- Add LICENSE and NOTICE in war packaging
- Update README.md for source distribution
- Update bin-dist-files/README for binary distribution
Have some questions :
- LICENSE and NOTICE in lens-server.war looks the following. Is this acceptable?
$ ls webapp/lens-server/
META-INF/ WEB-INF/ static/
$ ls webapp/lens-server/META-INF/
MANIFEST.MF maven/
$ ls webapp/lens-server/WEB-INF/
classes/ lib/ log4j.properties web.xml
$ ls webapp/lens-server/WEB-INF/classes/
META-INF/ lens-build-info.properties lensserver-default.xml lenssession-default.xml org/
$ ls webapp/lens-server/WEB-INF/classes/META-INF/
DEPENDENCIES LICENSE NOTICE
- Is it ok to have README file README.md for source distribution?
- bin-dist-files folder is included in src distribution. Is it acceptable?
Diffs (updated)
-----
README.md 07a3249
bin-dist-files/README 3e74fb9
lens-api/pom.xml b955c1a
lens-cli/pom.xml 26adc54
lens-client/pom.xml e56df03
lens-cube/pom.xml 274d1ea
lens-dist/pom.xml ddebf16
lens-driver-hive/pom.xml be0c1b7
lens-driver-jdbc/pom.xml daab50d
lens-examples/pom.xml 2163785
lens-ml-lib/pom.xml 3cdca92
lens-query-lib/pom.xml 95d9d93
lens-regression/pom.xml d506eaa
lens-server-api/pom.xml f490dee
lens-server/pom.xml 0986ab9
lens-storage-db/pom.xml fb35e12
pom.xml 38d1693
src/site/apt/developer/contribute.apt 91e7b81
src/site/apt/lenshome/install-and-run.apt 6031cf9
src/site/apt/releases/release-history.apt f5f6139
Diff: https://reviews.apache.org/r/31116/diff/
Testing
-------
Verified packaging is fine by untarring the distribution. Will do some more testing and update here.
Thanks,
Amareshwari Sriramadasu
Re: Review Request 31116: LENS-311 : Packaging and README update for
source and binary distribution
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Feb. 17, 2015, 6:44 p.m., Chris Douglas wrote:
> > pom.xml, line 1087
> > <https://reviews.apache.org/r/31116/diff/1/?file=866339#file866339line1087>
> >
> > Should this exclusion be in the dependencies section, rather than a special profile? If one pulls the source, will the default build pull the GPL dep?
Not required. Licensing norms are only for bundled jars. building the project can pull any licensed jars as answered here - http://www.apache.org/legal/resolved.html#prohibited
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31116/#review72743
-----------------------------------------------------------
On Feb. 18, 2015, 5:25 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31116/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 5:25 a.m.)
>
>
> Review request for lens, Chris Douglas and Srikanth Sundarrajan.
>
>
> Bugs: LENS-311
> https://issues.apache.org/jira/browse/LENS-311
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Change source release artifact name to include apache-lens. Changed lens-parent to apache-lens.
> - Add exclusion for org.acplt:oncrpc in apache-release profile
> - Add LICENSE and NOTICE in war packaging
> - Update README.md for source distribution
> - Update bin-dist-files/README for binary distribution
>
> Have some questions :
> - LICENSE and NOTICE in lens-server.war looks the following. Is this acceptable?
> $ ls webapp/lens-server/
> META-INF/ WEB-INF/ static/
>
> $ ls webapp/lens-server/META-INF/
> MANIFEST.MF maven/
>
> $ ls webapp/lens-server/WEB-INF/
> classes/ lib/ log4j.properties web.xml
>
> $ ls webapp/lens-server/WEB-INF/classes/
> META-INF/ lens-build-info.properties lensserver-default.xml lenssession-default.xml org/
>
> $ ls webapp/lens-server/WEB-INF/classes/META-INF/
> DEPENDENCIES LICENSE NOTICE
>
> - Is it ok to have README file README.md for source distribution?
> - bin-dist-files folder is included in src distribution. Is it acceptable?
>
>
> Diffs
> -----
>
> README.md 07a3249
> bin-dist-files/README 3e74fb9
> lens-api/pom.xml b955c1a
> lens-cli/pom.xml 26adc54
> lens-client/pom.xml e56df03
> lens-cube/pom.xml 274d1ea
> lens-dist/pom.xml ddebf16
> lens-driver-hive/pom.xml be0c1b7
> lens-driver-jdbc/pom.xml daab50d
> lens-examples/pom.xml 2163785
> lens-ml-lib/pom.xml 3cdca92
> lens-query-lib/pom.xml 95d9d93
> lens-regression/pom.xml d506eaa
> lens-server-api/pom.xml f490dee
> lens-server/pom.xml 0986ab9
> lens-storage-db/pom.xml fb35e12
> pom.xml 38d1693
> src/site/apt/developer/contribute.apt 91e7b81
> src/site/apt/lenshome/install-and-run.apt 6031cf9
> src/site/apt/releases/release-history.apt f5f6139
>
> Diff: https://reviews.apache.org/r/31116/diff/
>
>
> Testing
> -------
>
> Verified packaging is fine by untarring the distribution. Will do some more testing and update here.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 31116: LENS-311 : Packaging and README update for
source and binary distribution
Posted by Chris Douglas <cd...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31116/#review72743
-----------------------------------------------------------
> Is it ok to have README file README.md for source distribution?
Yes
> bin-dist-files folder is included in src distribution. Is it acceptable?
Yes
bin-dist-files/README
<https://reviews.apache.org/r/31116/#comment118816>
Using markdown; README.md or convert?
bin-dist-files/README
<https://reviews.apache.org/r/31116/#comment118818>
s/atleast/at least/
pom.xml
<https://reviews.apache.org/r/31116/#comment118798>
Should this exclusion be in the dependencies section, rather than a special profile? If one pulls the source, will the default build pull the GPL dep?
- Chris Douglas
On Feb. 17, 2015, 3:33 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31116/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 3:33 p.m.)
>
>
> Review request for lens, Chris Douglas and Srikanth Sundarrajan.
>
>
> Bugs: LENS-311
> https://issues.apache.org/jira/browse/LENS-311
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Change source release artifact name to include apache-lens. Changed lens-parent to apache-lens.
> - Add exclusion for org.acplt:oncrpc in apache-release profile
> - Add LICENSE and NOTICE in war packaging
> - Update README.md for source distribution
> - Update bin-dist-files/README for binary distribution
>
> Have some questions :
> - LICENSE and NOTICE in lens-server.war looks the following. Is this acceptable?
> $ ls webapp/lens-server/
> META-INF/ WEB-INF/ static/
>
> $ ls webapp/lens-server/META-INF/
> MANIFEST.MF maven/
>
> $ ls webapp/lens-server/WEB-INF/
> classes/ lib/ log4j.properties web.xml
>
> $ ls webapp/lens-server/WEB-INF/classes/
> META-INF/ lens-build-info.properties lensserver-default.xml lenssession-default.xml org/
>
> $ ls webapp/lens-server/WEB-INF/classes/META-INF/
> DEPENDENCIES LICENSE NOTICE
>
> - Is it ok to have README file README.md for source distribution?
> - bin-dist-files folder is included in src distribution. Is it acceptable?
>
>
> Diffs
> -----
>
> README.md 07a3249
> bin-dist-files/README 3e74fb9
> lens-api/pom.xml b955c1a
> lens-cli/pom.xml 26adc54
> lens-client/pom.xml e56df03
> lens-cube/pom.xml 274d1ea
> lens-dist/pom.xml ddebf16
> lens-driver-hive/pom.xml be0c1b7
> lens-driver-jdbc/pom.xml daab50d
> lens-examples/pom.xml 2163785
> lens-ml-lib/pom.xml 3cdca92
> lens-query-lib/pom.xml 95d9d93
> lens-regression/pom.xml d506eaa
> lens-server-api/pom.xml f490dee
> lens-server/pom.xml 0986ab9
> lens-storage-db/pom.xml fb35e12
> pom.xml 38d1693
> src/site/apt/lenshome/install-and-run.apt 6031cf9
> src/site/apt/releases/release-history.apt f5f6139
>
> Diff: https://reviews.apache.org/r/31116/diff/
>
>
> Testing
> -------
>
> Verified packaging is fine by untarring the distribution. Will do some more testing and update here.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>