[GitHub] [rocketmq-connect] fireroundgithub commented on a diff in pull request #382: [ISSUE #366] Support for sftp connector（sinlk & source）

[GitBox <gi...@apache.org>]

fireroundgithub commented on code in PR #382:
URL: https://github.com/apache/rocketmq-connect/pull/382#discussion_r1030089318


##########
connectors/rocketmq-connect-sftp/src/main/java/org/apache/rocketmq/connect/http/sink/SftpSinkTask.java:
##########
@@ -0,0 +1,67 @@
+package org.apache.rocketmq.connect.http.sink;
+
+import io.openmessaging.KeyValue;
+import io.openmessaging.connector.api.component.task.sink.SinkTask;
+import io.openmessaging.connector.api.data.ConnectRecord;
+import io.openmessaging.connector.api.errors.ConnectException;
+import org.apache.commons.lang3.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.util.List;
+
+import static org.apache.rocketmq.connect.http.sink.SftpConstant.*;
+
+public class SftpSinkTask extends SinkTask {
+    private static final Logger log = LoggerFactory.getLogger(SftpSinkTask.class);
+
+    private SftpClient sftpClient;
+
+    private String filename;
+
+    @Override
+    public void put(List<ConnectRecord> sinkRecords) throws ConnectException {
+        try {
+            for (ConnectRecord connectRecord : sinkRecords) {
+                String str = (String) connectRecord.getData();
+                str = str + System.lineSeparator();
+                sftpClient.append(new ByteArrayInputStream(str.getBytes()), filename);
+            }
+        } catch (IOException e) {
+            log.error("sink task ioexception", e);
+        } finally {
+            sftpClient.close();
+        }
+        sinkRecords.forEach(System.out::println);
+    }
+
+    @Override
+    public void validate(KeyValue config) {
+        if (StringUtils.isBlank(config.getString(SFTP_HOST_KEY))
+                || StringUtils.isBlank(config.getString(SFTP_PORT_KEY))
+                || StringUtils.isBlank(config.getString(SFTP_USERNAME_KEY))
+                || StringUtils.isBlank(config.getString(SFTP_PASSWORD_KEY))
+                || StringUtils.isBlank(config.getString(SFTP_PATH_KEY))
+                || StringUtils.isBlank(config.getString(SFTP_FILENAME_KEY))) {
+            throw new RuntimeException("missing required config");
+        }
+    }
+
+    @Override
+    public void start(KeyValue config) {
+        String host = config.getString(SFTP_HOST_KEY);
+        int port = config.getInt(SFTP_PORT_KEY);
+        String username = config.getString(SFTP_USERNAME_KEY);
+        String password = config.getString(SFTP_PASSWORD_KEY);
+        String path = config.getString(SFTP_PATH_KEY);
+        filename = config.getString(SFTP_FILENAME_KEY);
+        sftpClient = new SftpClient(host, port, username, password, path);
+    }
+
+    @Override
+    public void stop() {
+

Review Comment:
   It will be close after poll.



##########
connectors/rocketmq-connect-sftp/src/main/java/org/apache/rocketmq/connect/http/sink/SftpSourceTask.java:
##########
@@ -0,0 +1,120 @@
+package org.apache.rocketmq.connect.http.sink;
+
+import io.openmessaging.KeyValue;
+import io.openmessaging.connector.api.component.task.source.SourceTask;
+import io.openmessaging.connector.api.component.task.source.SourceTaskContext;
+import io.openmessaging.connector.api.data.ConnectRecord;
+import io.openmessaging.connector.api.data.RecordOffset;
+import io.openmessaging.connector.api.data.RecordPartition;
+import org.apache.commons.lang3.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.nio.file.FileSystemException;
+import java.util.*;
+
+import static org.apache.rocketmq.connect.http.sink.SftpConstant.*;
+
+public class SftpSourceTask extends SourceTask {
+
+    private final Logger log = LoggerFactory.getLogger(SftpConstant.LOGGER_NAME);
+
+    private SftpClient sftpClient;
+
+    private String filename;
+
+    private static final int MAX_NUMBER_SEND_CONNECT_RECORD_EACH_TIME = 2000;
+
+    @Override
+    public void init(SourceTaskContext sourceTaskContext) {
+        super.init(sourceTaskContext);
+    }
+
+    @Override
+    public void start(KeyValue config) {
+        String host = config.getString(SFTP_HOST_KEY);
+        int port = config.getInt(SFTP_PORT_KEY);
+        String username = config.getString(SFTP_USERNAME_KEY);
+        String password = config.getString(SFTP_PASSWORD_KEY);
+        String path = config.getString(SFTP_PATH_KEY);
+        filename = config.getString(SFTP_FILENAME_KEY);
+        sftpClient = new SftpClient(host, port, username, password, path);
+    }
+
+    @Override
+    public void stop() {
+    }

Review Comment:
   It will be close after poll.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org