You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Guozhang Wang <wa...@gmail.com> on 2015/03/13 23:26:31 UTC

Review Request 32061: WIP for KAFKA-2015 plus some minor fixes in new consumer

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32061/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-2015
    https://issues.apache.org/jira/browse/KAFKA-2015


Repository: kafka


Description
-------

NOTE: without the rebalance implementation a single consumer will try to subscribe to all partitions of the given topic.


Diffs
-----

  clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java 436f9b2a843bc8c44d17403f5880b6736a5d56a8 
  clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java 8b71fbad5c404d3f23137e153d6376de9f82b823 
  config/tools-log4j.properties 52f07c96019b4083fc78f62cfb0a81080327e847 
  core/src/main/scala/kafka/consumer/BaseConsumer.scala PRE-CREATION 
  core/src/main/scala/kafka/tools/ConsoleConsumer.scala 910691e88ccc66a1542d0ea85bb2f732861d805e 
  core/src/main/scala/kafka/tools/ConsoleProducer.scala 00265f9f4a4b6c6a9aa023e5be5faf297f77bf31 

Diff: https://reviews.apache.org/r/32061/diff/


Testing
-------


Thanks,

Guozhang Wang


Re: Review Request 32061: WIP for KAFKA-2015 plus some minor fixes in new consumer

Posted by Onur Karaman <ok...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32061/#review76630
-----------------------------------------------------------

Ship it!


Ship It!

- Onur Karaman


On March 13, 2015, 10:26 p.m., Guozhang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32061/
> -----------------------------------------------------------
> 
> (Updated March 13, 2015, 10:26 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2015
>     https://issues.apache.org/jira/browse/KAFKA-2015
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> NOTE: without the rebalance implementation a single consumer will try to subscribe to all partitions of the given topic.
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java 436f9b2a843bc8c44d17403f5880b6736a5d56a8 
>   clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java 8b71fbad5c404d3f23137e153d6376de9f82b823 
>   config/tools-log4j.properties 52f07c96019b4083fc78f62cfb0a81080327e847 
>   core/src/main/scala/kafka/consumer/BaseConsumer.scala PRE-CREATION 
>   core/src/main/scala/kafka/tools/ConsoleConsumer.scala 910691e88ccc66a1542d0ea85bb2f732861d805e 
>   core/src/main/scala/kafka/tools/ConsoleProducer.scala 00265f9f4a4b6c6a9aa023e5be5faf297f77bf31 
> 
> Diff: https://reviews.apache.org/r/32061/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guozhang Wang
> 
>