You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry via Review Board <no...@reviews.apache.org> on 2021/10/04 15:42:19 UTC
Re: Review Request 73286: Initial commit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73286/#review223560
-----------------------------------------------------------
Can you please rebase this against latest master?
- Ashutosh Mestry
On Sept. 3, 2021, 7:42 a.m., Aileen Toleikis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73286/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2021, 7:42 a.m.)
>
>
> Review request for atlas.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> The Kafka Community is using Schema Registry more and more heavily but as Atlas is currently unaware of this, this extension helps Atlas make use of the Schemas.
>
> We have tested this extension and we have production environments where Atlas will not be allowed without schema registry access. We have received feedback that this extension would be sufficient to allow production use.
>
> Changes:
>
> initial commit
>
>
> added schema creation in Atlas
>
>
> added Schema creation, Schema linkage and started to work on versions
>
>
> avro_field creation is working. However, there is no connection to schemas yet
>
>
> smaller refactorings and improved logging
>
>
> added field reference in schemas
>
>
> deleted second README and added gitignore
>
>
> Smaller changes after rebasing on new version
>
>
> moved HTTP REST calls to a separate class (SchemaRegistryConnector.java)
>
>
> added testCreateSchema() as test case
>
>
> added testCreateField() and testUpdateField() as test case
>
>
> added testGetSchemas() and testGetSchemaVersions() as test case
>
>
> added testUpdateSchema() as test case
>
>
> removed unnecessary comments
>
>
> Diffs
> -----
>
> addons/kafka-bridge/pom.xml 7fe97eb39897e32f5e2a4104cc06948e1ec48b27
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java bf74c67454120e3bdeebab0d7cc428d6bba8c021
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/SchemaRegistryConnector.java PRE-CREATION
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/model/KafkaDataTypes.java 0f81b4c37a1d8f84c587a914eb460b290ae36987
> addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java f86ceb58fd250d80f3ae3c71085c8c0adbc9116b
> pom.xml 092ba09cee93ca703e29d8ae1afaa20559a06227
>
>
> Diff: https://reviews.apache.org/r/73286/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aileen Toleikis
>
>
Re: Review Request 73286: Initial commit
Posted by Aileen Toleikis <ai...@hpe.com>.
> On Okt. 4, 2021, 3:42 nachm., Ashutosh Mestry wrote:
> > Can you please rebase this against latest master?
Hi Ashutosh!
We rebased our code to the latest master!
And we also added schema evolution to the code, therefore there are more new codelines in the diff.
How do we proceed from here?
Kind regards,
Aileen
- Aileen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73286/#review223560
-----------------------------------------------------------
On Okt. 5, 2021, 8:06 vorm., Aileen Toleikis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73286/
> -----------------------------------------------------------
>
> (Updated Okt. 5, 2021, 8:06 vorm.)
>
>
> Review request for atlas.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> The Kafka Community is using Schema Registry more and more heavily but as Atlas is currently unaware of this, this extension helps Atlas make use of the Schemas.
>
> We have tested this extension and we have production environments where Atlas will not be allowed without schema registry access. We have received feedback that this extension would be sufficient to allow production use.
>
> Changes:
>
> initial commit
>
>
> added schema creation in Atlas
>
>
> added Schema creation, Schema linkage and started to work on versions
>
>
> avro_field creation is working. However, there is no connection to schemas yet
>
>
> smaller refactorings and improved logging
>
>
> added field reference in schemas
>
>
> deleted second README and added gitignore
>
>
> Smaller changes after rebasing on new version
>
>
> moved HTTP REST calls to a separate class (SchemaRegistryConnector.java)
>
>
> added testCreateSchema() as test case
>
>
> added testCreateField() and testUpdateField() as test case
>
>
> added testGetSchemas() and testGetSchemaVersions() as test case
>
>
> added testUpdateSchema() as test case
>
>
> removed unnecessary comments
>
>
> Diffs
> -----
>
> addons/kafka-bridge/pom.xml 2ac19fd20e0c0322b0d104641ddd5a2ef89bf9d0
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java f9548244364a8f79f346411739348d0d53298c99
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/SchemaRegistryConnector.java PRE-CREATION
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/model/KafkaDataTypes.java 0f81b4c37a1d8f84c587a914eb460b290ae36987
> addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java f86ceb58fd250d80f3ae3c71085c8c0adbc9116b
> pom.xml 47768e9fa7d8abcfc81cd148917400ac478a333a
>
>
> Diff: https://reviews.apache.org/r/73286/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aileen Toleikis
>
>
Re: Review Request 73286: Initial commit
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
> On Oct. 4, 2021, 3:42 p.m., Ashutosh Mestry wrote:
> > Can you please rebase this against latest master?
>
> Aileen Toleikis wrote:
> Hi Ashutosh!
> We rebased our code to the latest master!
> And we also added schema evolution to the code, therefore there are more new codelines in the diff.
> How do we proceed from here?
> Kind regards,
> Aileen
Thanks! I have asked Viktor from our Kafka team to review the changes.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73286/#review223560
-----------------------------------------------------------
On Oct. 5, 2021, 8:06 a.m., Aileen Toleikis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73286/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2021, 8:06 a.m.)
>
>
> Review request for atlas.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> The Kafka Community is using Schema Registry more and more heavily but as Atlas is currently unaware of this, this extension helps Atlas make use of the Schemas.
>
> We have tested this extension and we have production environments where Atlas will not be allowed without schema registry access. We have received feedback that this extension would be sufficient to allow production use.
>
> Changes:
>
> initial commit
>
>
> added schema creation in Atlas
>
>
> added Schema creation, Schema linkage and started to work on versions
>
>
> avro_field creation is working. However, there is no connection to schemas yet
>
>
> smaller refactorings and improved logging
>
>
> added field reference in schemas
>
>
> deleted second README and added gitignore
>
>
> Smaller changes after rebasing on new version
>
>
> moved HTTP REST calls to a separate class (SchemaRegistryConnector.java)
>
>
> added testCreateSchema() as test case
>
>
> added testCreateField() and testUpdateField() as test case
>
>
> added testGetSchemas() and testGetSchemaVersions() as test case
>
>
> added testUpdateSchema() as test case
>
>
> removed unnecessary comments
>
>
> Diffs
> -----
>
> addons/kafka-bridge/pom.xml 2ac19fd20e0c0322b0d104641ddd5a2ef89bf9d0
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java f9548244364a8f79f346411739348d0d53298c99
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/SchemaRegistryConnector.java PRE-CREATION
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/model/KafkaDataTypes.java 0f81b4c37a1d8f84c587a914eb460b290ae36987
> addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java f86ceb58fd250d80f3ae3c71085c8c0adbc9116b
> pom.xml 47768e9fa7d8abcfc81cd148917400ac478a333a
>
>
> Diff: https://reviews.apache.org/r/73286/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aileen Toleikis
>
>