You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/06/23 20:56:15 UTC
[GitHub] [arrow-adbc] lidavidm opened a new pull request, #846: build(c): properly install missing symlink on Windows
lidavidm opened a new pull request, #846:
URL: https://github.com/apache/arrow-adbc/pull/846
Also see #634.
Fixes #840.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm merged pull request #846: build(c): properly install missing symlink on Windows
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #846:
URL: https://github.com/apache/arrow-adbc/pull/846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] kou commented on a diff in pull request #846: build(c): properly install missing symlink on Windows
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #846:
URL: https://github.com/apache/arrow-adbc/pull/846#discussion_r1240625668
##########
c/cmake_modules/GoUtils.cmake:
##########
@@ -204,6 +204,9 @@ function(add_go_lib GO_MOD_DIR GO_LIBNAME)
endif()
if(NOT WIN32)
install(FILES "${LIBOUT_SHARED}" "${LIBOUT_SHARED}.${ADBC_SO_VERSION}" TYPE LIB)
+ else()
+ # This symlink doesn't get installed
+ install(FILES "${LIBOUT_SHARED}.${ADBC_SO_VERSION}" TYPE BIN)
Review Comment:
We may want to invert this condition for readability:
```suggestion
if(WIN32)
# This symlink doesn't get installed
install(FILES "${LIBOUT_SHARED}.${ADBC_SO_VERSION}" TYPE BIN)
else()
install(FILES "${LIBOUT_SHARED}" "${LIBOUT_SHARED}.${ADBC_SO_VERSION}" TYPE LIB)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org