You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "seawinde (via GitHub)" <gi...@apache.org> on 2026/04/03 04:03:02 UTC
[PR] [fix](lineage) Propagate connectAttributes through FE forward path for scheduleInfo [doris]
seawinde opened a new pull request, #62082:
URL: https://github.com/apache/doris/pull/62082
## Problem
When a MySQL client (e.g., DataWorks/SKYNET) connects to a **follower FE**, the `scheduleInfo` connection attribute is lost in the lineage `queryText` output.
In HA mode, DML statements are forwarded from follower FE to master FE via thrift RPC. The `TMasterOpRequest` had no field for `connect_attributes`, causing them to be silently dropped. The master FE creates an empty `ConnectContext`, so `LineageUtils.buildLineageContext()` produces `queryText` without the `/* scheduleInfo={...} */` prefix.
## Fix
1. **Thrift**: Add `connect_attributes` (field 33) to `TMasterOpRequest`
2. **FEOpExecutor**: Serialize `connectAttributes` into forward params (inherited by `MasterOpExecutor`)
3. **ConnectProcessor**: Restore `connectAttributes` in `proxyExecute()` on master FE
## Testing
- `ConnectContextTest`: 4 tests for connectAttributes get/set, defensive copy, null/empty handling
- `ConnectAttributesForwardTest`: 5 tests for forward path round-trip including scheduleInfo
## Files Changed
| File | Change |
|------|--------|
| `gensrc/thrift/FrontendService.thrift` | Add `connect_attributes` to `TMasterOpRequest` |
| `fe/.../qe/FEOpExecutor.java` | Serialize connectAttributes in forward params |
| `fe/.../qe/ConnectProcessor.java` | Restore connectAttributes in `proxyExecute()` |
| `fe/.../mysql/MysqlAuthPacket.java` | Fix stale comment |
| + 2 test files | 9 new test cases |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lineage) Propagate connectAttributes through FE forward path for scheduleInfo [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #62082:
URL: https://github.com/apache/doris/pull/62082#issuecomment-4181715098
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lineage) Propagate connectAttributes through FE forward path for scheduleInfo [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde merged PR #62082:
URL: https://github.com/apache/doris/pull/62082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lineage) Propagate connectAttributes through FE forward path for scheduleInfo [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #62082:
URL: https://github.com/apache/doris/pull/62082#issuecomment-4182224213
<details>
<summary>TPC-H: <b>Total hot run time: 29023 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 27c58cdfc1c274a058d6c80cf0c869c0e3a378b5, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17665 3671 3652 3652
q2 q3 10679 893 618 618
q4 4687 461 362 362
q5 7466 1347 1144 1144
q6 185 166 139 139
q7 914 990 769 769
q8 9313 1410 1301 1301
q9 5571 5287 5262 5262
q10 6269 2029 1781 1781
q11 480 270 278 270
q12 631 404 276 276
q13 18070 2797 2161 2161
q14 285 285 272 272
q15 q16 871 839 790 790
q17 1081 1170 820 820
q18 6507 5703 5593 5593
q19 1162 1273 1077 1077
q20 526 420 276 276
q21 4091 2470 2074 2074
q22 518 441 386 386
Total cold run time: 96971 ms
Total hot run time: 29023 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4568 4511 4626 4511
q2 q3 4667 4723 4144 4144
q4 2018 2086 1326 1326
q5 4879 4940 5199 4940
q6 196 166 128 128
q7 2006 1767 1646 1646
q8 3482 3102 3075 3075
q9 8201 8440 8351 8351
q10 4488 4527 4298 4298
q11 709 409 398 398
q12 653 705 499 499
q13 2686 3063 2277 2277
q14 307 296 273 273
q15 q16 747 783 696 696
q17 1264 1280 1210 1210
q18 7966 7065 7283 7065
q19 1145 1147 1088 1088
q20 2294 2292 1917 1917
q21 6023 5362 4748 4748
q22 556 509 421 421
Total cold run time: 58855 ms
Total hot run time: 53011 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lineage) Propagate connectAttributes through FE forward path for scheduleInfo [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62082:
URL: https://github.com/apache/doris/pull/62082#issuecomment-4197051307
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lineage) Propagate connectAttributes through FE forward path for scheduleInfo [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62082:
URL: https://github.com/apache/doris/pull/62082#issuecomment-4197051464
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lineage) Propagate connectAttributes through FE forward path for scheduleInfo [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62082:
URL: https://github.com/apache/doris/pull/62082#issuecomment-4182780072
# BE Regression && UT Coverage Report
Increment line coverage `90.38% (47/52)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62082_27c58cdfc1c274a058d6c80cf0c869c0e3a378b5_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62082_27c58cdfc1c274a058d6c80cf0c869c0e3a378b5_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.57% (27303/37114) |
| Line Coverage | 57.18% (294136/514367) |
| Region Coverage | 54.29% (244578/450527) |
| Branch Coverage | 56.10% (106266/189422) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lineage) Propagate connectAttributes through FE forward path for scheduleInfo [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62082:
URL: https://github.com/apache/doris/pull/62082#issuecomment-4182397301
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/27c58cdfc1c274a058d6c80cf0c869c0e3a378b5_27c58cdfc1c274a058d6c80cf0c869c0e3a378b5/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/27c58cdfc1c274a058d6c80cf0c869c0e3a378b5_27c58cdfc1c274a058d6c80cf0c869c0e3a378b5/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.99% (20081/37895) |
| Line Coverage | 36.56% (188648/515938) |
| Region Coverage | 32.82% (146486/446389) |
| Branch Coverage | 33.97% (64153/188840) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lineage) Propagate connectAttributes through FE forward path for scheduleInfo [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62082:
URL: https://github.com/apache/doris/pull/62082#issuecomment-4182657568
# BE Regression && UT Coverage Report
Increment line coverage `93.10% (27/29)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62082_27c58cdfc1c274a058d6c80cf0c869c0e3a378b5_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62082_27c58cdfc1c274a058d6c80cf0c869c0e3a378b5_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.54% (27295/37114) |
| Line Coverage | 57.16% (294011/514367) |
| Region Coverage | 54.24% (244376/450527) |
| Branch Coverage | 56.06% (106190/189422) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lineage) Propagate connectAttributes through FE forward path for scheduleInfo [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62082:
URL: https://github.com/apache/doris/pull/62082#issuecomment-4181712577
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lineage) Propagate connectAttributes through FE forward path for scheduleInfo [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62082:
URL: https://github.com/apache/doris/pull/62082#issuecomment-4182421082
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62082_27c58cdfc1c274a058d6c80cf0c869c0e3a378b5_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62082_27c58cdfc1c274a058d6c80cf0c869c0e3a378b5_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.54% (27295/37114) |
| Line Coverage | 57.16% (294011/514367) |
| Region Coverage | 54.24% (244376/450527) |
| Branch Coverage | 56.06% (106190/189422) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lineage) Propagate connectAttributes through FE forward path for scheduleInfo [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62082:
URL: https://github.com/apache/doris/pull/62082#issuecomment-4181841852
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/27c58cdfc1c274a058d6c80cf0c869c0e3a378b5_27c58cdfc1c274a058d6c80cf0c869c0e3a378b5_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/27c58cdfc1c274a058d6c80cf0c869c0e3a378b5_27c58cdfc1c274a058d6c80cf0c869c0e3a378b5_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 78.48% (1798/2291) |
| Line Coverage | 64.14% (32270/50310) |
| Region Coverage | 65.03% (16183/24886) |
| Branch Coverage | 55.47% (8621/15542) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lineage) Propagate connectAttributes through FE forward path for scheduleInfo [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62082:
URL: https://github.com/apache/doris/pull/62082#issuecomment-4181951514
# FE UT Coverage Report
Increment line coverage ` 0.00% (0/5)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62082_27c58cdfc1c274a058d6c80cf0c869c0e3a378b5/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62082_27c58cdfc1c274a058d6c80cf0c869c0e3a378b5/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lineage) Propagate connectAttributes through FE forward path for scheduleInfo [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #62082:
URL: https://github.com/apache/doris/pull/62082#issuecomment-4182258428
<details>
<summary>TPC-DS: <b>Total hot run time: 178933 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 27c58cdfc1c274a058d6c80cf0c869c0e3a378b5, data reload: false
query5 4349 674 517 517
query6 340 235 200 200
query7 4287 600 362 362
query8 336 245 221 221
query9 8739 3900 3901 3900
query10 470 367 315 315
query11 6836 5482 5151 5151
query12 184 139 127 127
query13 1288 641 521 521
query14 5625 5208 4746 4746
query14_1 4173 4146 4153 4146
query15 226 205 187 187
query16 1003 497 483 483
query17 1089 798 664 664
query18 2482 499 393 393
query19 232 225 184 184
query20 149 134 133 133
query21 223 145 139 139
query22 13940 14922 14503 14503
query23 17991 17080 16649 16649
query23_1 16770 17006 16826 16826
query24 7543 1762 1398 1398
query24_1 1368 1335 1350 1335
query25 594 496 427 427
query26 1257 324 176 176
query27 2665 653 369 369
query28 4421 1909 1865 1865
query29 977 669 569 569
query30 304 234 192 192
query31 1087 1030 977 977
query32 98 74 69 69
query33 546 364 284 284
query34 1210 1139 678 678
query35 737 776 657 657
query36 1277 1282 1093 1093
query37 156 96 95 95
query38 3104 3022 3042 3022
query39 939 902 856 856
query39_1 842 845 832 832
query40 276 148 131 131
query41 62 60 59 59
query42 110 103 105 103
query43 310 320 272 272
query44
query45 208 193 190 190
query46 1133 1249 770 770
query47 2357 2382 2248 2248
query48 428 423 297 297
query49 635 531 420 420
query50 751 285 224 224
query51 4434 4326 4312 4312
query52 109 110 96 96
query53 251 280 202 202
query54 317 274 279 274
query55 100 94 87 87
query56 303 323 313 313
query57 1709 1688 1615 1615
query58 291 272 275 272
query59 2876 3000 2731 2731
query60 339 341 320 320
query61 162 157 157 157
query62 676 635 576 576
query63 238 197 199 197
query64 5346 1357 1012 1012
query65
query66 1469 487 375 375
query67 24417 24221 24121 24121
query68
query69 455 338 311 311
query70 976 998 940 940
query71 309 288 269 269
query72 3053 2754 2446 2446
query73 849 773 452 452
query74 9776 9748 9572 9572
query75 2769 2641 2324 2324
query76 2304 1135 753 753
query77 398 399 333 333
query78 11304 11321 10772 10772
query79 1547 1015 845 845
query80 1355 579 488 488
query81 523 279 238 238
query82 1026 159 125 125
query83 365 292 267 267
query84 285 158 123 123
query85 935 498 450 450
query86 443 314 318 314
query87 3260 3250 3078 3078
query88 3644 2716 2757 2716
query89 439 402 364 364
query90 1983 184 177 177
query91 182 168 144 144
query92 78 75 72 72
query93 1228 972 567 567
query94 710 329 298 298
query95 645 361 423 361
query96 1078 762 367 367
query97 2705 2693 2561 2561
query98 238 225 223 223
query99 1069 1066 963 963
Total cold run time: 258264 ms
Total hot run time: 178933 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org