You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/21 18:57:00 UTC
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058024#comment-16058024 ]
ASF GitHub Bot commented on CB-12361:
-------------------------------------
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-lib/pull/567
CB-12361: Added unit tests for prepare.js
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### What does this PR do?
Add unit tests for prepare.js in prepare.spec.js.
### What testing has been done on this change?
npm run cover lists prepare.js at 97.4
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-lib prepare-specs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/567.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #567
----
commit 418973c718dd804de79dee1577f6dd54d81d537b
Author: filmaj <ma...@gmail.com>
Date: 2017-06-19T21:04:25Z
removed restoring platforms+plugins save.spec from prepare. rewrote structure of prepare unit tests, and included coverage for restoring platforms+plugins. slight changes to prepare.js so it leverages its own helper methods via its own export (helpful for testing).
commit 458f08b88b07862dff01dac01feff788771c03fa
Author: Steve Gill <st...@gmail.com>
Date: 2017-06-20T07:52:57Z
CB-12361: added unit tests for prepare.spec.js
commit d01b76870e838cec00c273a950a4acf76bcdedf3
Author: Steve Gill <st...@gmail.com>
Date: 2017-06-21T18:52:07Z
CB-12361: wrapped up prepare.js unit tests
----
> Speed up cordova-lib tests
> --------------------------
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
> Reporter: Steve Gill
> Assignee: Steve Gill
> Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org