[GitHub] [spark] amaliujia commented on a diff in pull request #38347: [SPARK-40883][CONNECT] Support Range in Connect proto

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38347:
URL: https://github.com/apache/spark/pull/38347#discussion_r1002850714


##########
connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectSessionBasedSuite.scala:
##########
@@ -32,7 +35,9 @@ trait SparkConnectPlanTestWithSparkSession extends SharedSparkSession with Spark
   override def getSession(): SparkSession = spark
 }
 
-class SparkConnectDeduplicateSuite extends SparkConnectPlanTestWithSparkSession {
+class SparkConnectSessionBasedSuite extends SparkConnectPlanTestWithSparkSession {

Review Comment:
   I am working on a refactoring PR but that is blocked. Let's have a discussion on how to unblock it.
   
   With the refactoring I expect we only have one suite that test Connect proto with DataFrame API.
   
   Before that is done, right now we have two suites, one is with DataFrame API and another one is with Catalyst.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org