You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/16 21:35:22 UTC

[GitHub] [arrow] kou commented on a change in pull request #8941: ARROW-10942: [C++] Fix S3FileSystem::Impl::IsEmptyDirectory on Amazon

kou commented on a change in pull request #8941:
URL: https://github.com/apache/arrow/pull/8941#discussion_r544639297



##########
File path: cpp/src/arrow/filesystem/s3fs.cc
##########
@@ -1241,6 +1245,13 @@ class S3FileSystem::Impl {
     return std::string(FromAwsString(builder_.config().region));
   }
 
+  template <typename Error>
+  void SaveBackend(const Aws::Client::AWSError<Error>& error) {
+    if (!backend_ || *backend_ == S3Backend::Other) {

Review comment:
       Do we need this condition?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org