[GitHub] [airflow] ashb commented on a change in pull request #7038: [AIRFLOW-4495] allow externally triggered dags to run for future exec dates

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #7038: [AIRFLOW-4495] allow externally triggered dags to run for future exec dates
URL: https://github.com/apache/airflow/pull/7038#discussion_r365220747
 
 

 ##########
 File path: airflow/models/dag.py
 ##########
 @@ -778,16 +785,20 @@ def set_dependency(self, upstream_task_id, downstream_task_id):
     def get_task_instances(
             self, start_date=None, end_date=None, state=None, session=None):
         if not start_date:
+            # TODO why 30?
 
 Review comment:
   PLEASE do not add todo comments in the code. Either find out why and fix it or document it, or don't add the comment. This doesn't help anyone.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services