You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2013/01/31 09:43:14 UTC
Re: Review Request: add option to specify JobID and ActionID in SLA CLI
command
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9175/
-----------------------------------------------------------
(Updated Jan. 31, 2013, 8:43 a.m.)
Review request for oozie.
Summary (updated)
-----------------
add option to specify JobID and ActionID in SLA CLI command
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1189
This addresses bug OOZIE-1189.
https://issues.apache.org/jira/browse/OOZIE-1189
Diffs
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1440237
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1440237
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1440237
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsInfoXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForJobIdJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1440237
trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1440237
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForJobIdJPAExecutor.java PRE-CREATION
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1440237
Diff: https://reviews.apache.org/r/9175/diff/
Testing
-------
tested locally
Thanks,
Ryota Egashira
Re: Review Request: add option to specify JobID and ActionID in SLA CLI
command
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
> On Feb. 1, 2013, 7:47 p.m., Rohini Palaniswamy wrote:
> > trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java, line 373
> > <https://reviews.apache.org/r/9175/diff/1/?file=253789#file253789line373>
> >
> > Shouldn't it be -jobid if it takes jobid as input
yes, 1st version was uploaded before our discussion. now uploading new one.
- Ryota
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9175/#review16031
-----------------------------------------------------------
On Feb. 11, 2013, 11:40 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9175/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2013, 11:40 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1189
>
>
> This addresses bug OOZIE-1189.
> https://issues.apache.org/jira/browse/OOZIE-1189
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1444336
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1444336
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1444336
> trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1444336
> trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsFilterXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1444336
> trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1444336
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1444336
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1444320
>
> Diff: https://reviews.apache.org/r/9175/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: add option to specify JobID and ActionID in SLA CLI
command
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9175/#review16031
-----------------------------------------------------------
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/9175/#comment34328>
Shouldn't it be -jobid if it takes jobid as input
- Rohini Palaniswamy
On Jan. 31, 2013, 8:43 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9175/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2013, 8:43 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1189
>
>
> This addresses bug OOZIE-1189.
> https://issues.apache.org/jira/browse/OOZIE-1189
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1440237
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1440237
> trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1440237
> trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsInfoXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForJobIdJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1440237
> trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1440237
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForJobIdJPAExecutor.java PRE-CREATION
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1440237
>
> Diff: https://reviews.apache.org/r/9175/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: add option to specify JobID and appname in SLA CLI
command
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
> On Feb. 14, 2013, 9:04 p.m., Mona Chitnis wrote:
> > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java, line 121
> > <https://reviews.apache.org/r/9175/diff/3/?file=258600#file258600line121>
> >
> > so this means, from the command-line, we can pass comma-separated list of ids/appnames?
semi-colon separated list following convention of job filter,
> On Feb. 14, 2013, 9:04 p.m., Mona Chitnis wrote:
> > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java, line 131
> > <https://reviews.apache.org/r/9175/diff/3/?file=258600#file258600line131>
> >
> > should combined logic be rather AND?
this one still OR, since it translates to "where jobid in (ID1, ID2)"
- Ryota
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9175/#review16605
-----------------------------------------------------------
On Feb. 15, 2013, 8:32 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9175/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2013, 8:32 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1189
>
>
> This addresses bug OOZIE-1189.
> https://issues.apache.org/jira/browse/OOZIE-1189
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1446424
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1446424
> trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1446424
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1446424
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1446424
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1446424
>
> Diff: https://reviews.apache.org/r/9175/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: add option to specify JobID and appname in SLA CLI
command
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9175/#review16605
-----------------------------------------------------------
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java
<https://reviews.apache.org/r/9175/#comment35229>
Plus the two new constants are not used anywhere
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java
<https://reviews.apache.org/r/9175/#comment35230>
typo. should be sele*c*tStr
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java
<https://reviews.apache.org/r/9175/#comment35232>
so this means, from the command-line, we can pass comma-separated list of ids/appnames?
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java
<https://reviews.apache.org/r/9175/#comment35233>
should combined logic be rather AND?
- Mona Chitnis
On Feb. 13, 2013, 10:23 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9175/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 10:23 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1189
>
>
> This addresses bug OOZIE-1189.
> https://issues.apache.org/jira/browse/OOZIE-1189
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1444336
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1444336
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1444336
> trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1444336
> trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsFilterXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1444336
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1444336
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1444320
>
> Diff: https://reviews.apache.org/r/9175/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: add option to specify JobID and appname in SLA CLI
command
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
> On Feb. 14, 2013, 5:22 p.m., Rohini Palaniswamy wrote:
> > trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java, lines 82-83
> > <https://reviews.apache.org/r/9175/diff/3/?file=258599#file258599line82>
> >
> > Just thought about it. If you are using just appname filter, you should honour sequence id and max events also because there will be lot of events. So better to have one command that takes all the options (jobid, appname, maxevents and sequence id).
yes, agreed with this change. enabled offset/len when jobid/appname filter used.
> On Feb. 14, 2013, 5:22 p.m., Rohini Palaniswamy wrote:
> > trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java, line 147
> > <https://reviews.apache.org/r/9175/diff/3/?file=258599#file258599line147>
> >
> > Should probably go in some util class as this code is repeated in other places too
in case of workflow, parsing method is all in DagEngine, but it might not be good place for SLA thing.
since this method is only used here, also no other util method, I just kept it as it is , going forward, as more util methods, we can add util class.
- Ryota
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9175/#review16588
-----------------------------------------------------------
On Feb. 15, 2013, 8:32 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9175/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2013, 8:32 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1189
>
>
> This addresses bug OOZIE-1189.
> https://issues.apache.org/jira/browse/OOZIE-1189
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1446424
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1446424
> trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1446424
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1446424
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1446424
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1446424
>
> Diff: https://reviews.apache.org/r/9175/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: add option to specify JobID and appname in SLA CLI
command
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9175/#review16588
-----------------------------------------------------------
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java
<https://reviews.apache.org/r/9175/#comment35179>
File to be revereted. only has whitespace changes.
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java
<https://reviews.apache.org/r/9175/#comment35180>
File to be revereted. only has whitespace changes.
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsFilterXCommand.java
<https://reviews.apache.org/r/9175/#comment35170>
typo. Should be Filter
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsFilterXCommand.java
<https://reviews.apache.org/r/9175/#comment35171>
non-Javadoc comments should be removed
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java
<https://reviews.apache.org/r/9175/#comment35172>
rename to something like isFirst
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java
<https://reviews.apache.org/r/9175/#comment35173>
Can we do a separate condition for = (list size = 1) and IN clause
trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java
<https://reviews.apache.org/r/9175/#comment35174>
Just thought about it. If you are using just appname filter, you should honour sequence id and max events also because there will be lot of events. So better to have one command that takes all the options (jobid, appname, maxevents and sequence id).
trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java
<https://reviews.apache.org/r/9175/#comment35176>
Should probably go in some util class as this code is repeated in other places too
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/9175/#comment35177>
tab instead of space
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/9175/#comment35178>
workflow action id/coordinator action id
- Rohini Palaniswamy
On Feb. 13, 2013, 10:23 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9175/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 10:23 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1189
>
>
> This addresses bug OOZIE-1189.
> https://issues.apache.org/jira/browse/OOZIE-1189
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1444336
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1444336
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1444336
> trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1444336
> trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsFilterXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1444336
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1444336
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1444320
>
> Diff: https://reviews.apache.org/r/9175/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: add option to specify JobID and appname in SLA CLI
command
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9175/#review16666
-----------------------------------------------------------
Ship it!
Ship It!
- Mona Chitnis
On Feb. 15, 2013, 9:37 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9175/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2013, 9:37 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1189
>
>
> This addresses bug OOZIE-1189.
> https://issues.apache.org/jira/browse/OOZIE-1189
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1446424
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1446424
> trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1446424
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1446424
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1446424
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1446424
>
> Diff: https://reviews.apache.org/r/9175/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: add option to specify JobID and appname in SLA CLI
command
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9175/
-----------------------------------------------------------
(Updated Feb. 15, 2013, 9:37 p.m.)
Review request for oozie.
Changes
-------
sorry for spam. fixed some format.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1189
This addresses bug OOZIE-1189.
https://issues.apache.org/jira/browse/OOZIE-1189
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1446424
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1446424
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1446424
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1446424
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1446424
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1446424
Diff: https://reviews.apache.org/r/9175/diff/
Testing
-------
tested locally
Thanks,
Ryota Egashira
Re: Review Request: add option to specify JobID and appname in SLA CLI
command
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9175/
-----------------------------------------------------------
(Updated Feb. 15, 2013, 9:16 p.m.)
Review request for oozie.
Changes
-------
did final change
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1189
This addresses bug OOZIE-1189.
https://issues.apache.org/jira/browse/OOZIE-1189
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1446424
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1446424
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1446424
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1446424
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1446424
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1446424
Diff: https://reviews.apache.org/r/9175/diff/
Testing
-------
tested locally
Thanks,
Ryota Egashira
Re: Review Request: add option to specify JobID and appname in SLA CLI
command
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9175/#review16665
-----------------------------------------------------------
Very minor stuff.
trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java
<https://reviews.apache.org/r/9175/#comment35357>
Better error message. "gt-sequence-id parameter is not specified in the http request"
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/9175/#comment35356>
Tabs in few places in this file to be replaced with spaces
- Rohini Palaniswamy
On Feb. 15, 2013, 8:32 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9175/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2013, 8:32 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1189
>
>
> This addresses bug OOZIE-1189.
> https://issues.apache.org/jira/browse/OOZIE-1189
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1446424
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1446424
> trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1446424
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1446424
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1446424
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1446424
>
> Diff: https://reviews.apache.org/r/9175/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: add option to specify JobID and appname in SLA CLI
command
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9175/
-----------------------------------------------------------
(Updated Feb. 15, 2013, 8:32 p.m.)
Review request for oozie.
Changes
-------
modified based on Rohini/Mona's comments.
including
- enable offset and len for jobid/appname filter.
- for that, did consolidation (e.g., remove SLAEventsFilterXCommand, oozie cli change, etc)
- change examples a bit
did test locally, thanks for comments!
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1189
This addresses bug OOZIE-1189.
https://issues.apache.org/jira/browse/OOZIE-1189
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1446424
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1446424
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 1446424
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1446424
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1446424
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1446424
Diff: https://reviews.apache.org/r/9175/diff/
Testing
-------
tested locally
Thanks,
Ryota Egashira
Re: Review Request: add option to specify JobID and appname in SLA CLI
command
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9175/
-----------------------------------------------------------
(Updated Feb. 13, 2013, 10:23 p.m.)
Review request for oozie.
Changes
-------
cleaned up format change, hope it is easier to review now.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1189
This addresses bug OOZIE-1189.
https://issues.apache.org/jira/browse/OOZIE-1189
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1444336
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1444336
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1444336
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1444336
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsFilterXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1444336
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1444336
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1444320
Diff: https://reviews.apache.org/r/9175/diff/
Testing
-------
tested locally
Thanks,
Ryota Egashira
Re: Review Request: add option to specify JobID and appname in SLA CLI
command
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9175/#review16514
-----------------------------------------------------------
Can you upload a patch without the formatting changes? If you are setting auto format in eclipse save actions, you should remove that.
- Rohini Palaniswamy
On Feb. 12, 2013, 11:17 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9175/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2013, 11:17 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1189
>
>
> This addresses bug OOZIE-1189.
> https://issues.apache.org/jira/browse/OOZIE-1189
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1444336
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1444336
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1444336
> trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1444336
> trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsFilterXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1444336
> trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1444336
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1444336
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1444320
>
> Diff: https://reviews.apache.org/r/9175/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: add option to specify JobID and appname in SLA CLI
command
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9175/
-----------------------------------------------------------
(Updated Feb. 12, 2013, 11:17 p.m.)
Review request for oozie.
Summary (updated)
-----------------
add option to specify JobID and appname in SLA CLI command
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1189
This addresses bug OOZIE-1189.
https://issues.apache.org/jira/browse/OOZIE-1189
Diffs
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1444336
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1444336
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1444336
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1444336
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsFilterXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1444336
trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1444336
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1444336
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1444320
Diff: https://reviews.apache.org/r/9175/diff/
Testing
-------
tested locally
Thanks,
Ryota Egashira
Re: Review Request: add option to specify JobID and ActionID in SLA CLI
command
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9175/
-----------------------------------------------------------
(Updated Feb. 11, 2013, 11:40 p.m.)
Review request for oozie.
Changes
-------
added support of -filter <arg> option, jobid=<JobID/ActionID>;appname=<Application Name>
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1189
This addresses bug OOZIE-1189.
https://issues.apache.org/jira/browse/OOZIE-1189
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1444336
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1444336
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1444336
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1444336
trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsFilterXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1444336
trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1444336
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1444336
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1444320
Diff: https://reviews.apache.org/r/9175/diff/
Testing
-------
tested locally
Thanks,
Ryota Egashira