[GitHub] [cloudstack] GutoVeronezi edited a comment on pull request #4771: migrateVMWithVolume: Handle migrate vm with volume where data disk is not based off a template

[GitBox <gi...@apache.org>]

GutoVeronezi edited a comment on pull request #4771:
URL: https://github.com/apache/cloudstack/pull/4771#issuecomment-792780169


   > @GutoVeronezi I see that code is changed in different places than the code in this PR. Are you saying that PR makes this obsolete or do they merit merging each in their own right?
   
   @DaanHoogland Both PRs address the same problem, which is to handle the template id in case it is null (for data disks); the main difference is that, that this PR made validations out of the scope of the method, where it seems more interesting, as it verifies if we are handling a volume created from a template before calling the copy template method. Further, we added some logging to facilitate the life of operators if they ever need to troubleshoot this process.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org