Re: [PATCH] Expat patch #3

["Roy T. Fielding" <fi...@kiwi.ics.uci.edu>]

>Moving things in CVS is a little complicated.  If I recall
>correctly, the sequence for this should be:
>
>1. cvs add src/lib
>2. in the master CVS repository, copy the regex/ directory
>   and contents (regex/*,v) under lib/
>3. repeat for anything else moving
>4. cvs rm regex/* (and likewise for any other copied
>   directories)

WHOA!  Why is this being done in 1.3.x???  We don't screw with the
directory structure on minor versions, since third-party installation
scripts depend on the directory structure not changing haphazardly.

So, why on earth do we need a src/lib directory?  Aesthetics again?

....Roy

Re: [PATCH] Expat patch #3

[Greg Stein <gs...@lyra.org>]

Roy T. Fielding wrote:
> 
> >Moving things in CVS is a little complicated.  If I recall
> >correctly, the sequence for this should be:
> >
> >1. cvs add src/lib
> >2. in the master CVS repository, copy the regex/ directory
> >   and contents (regex/*,v) under lib/
> >3. repeat for anything else moving
> >4. cvs rm regex/* (and likewise for any other copied
> >   directories)
> 
> WHOA!  Why is this being done in 1.3.x???  We don't screw with the
> directory structure on minor versions, since third-party installation
> scripts depend on the directory structure not changing haphazardly.
> 
> So, why on earth do we need a src/lib directory?  Aesthetics again?

hehe... *just* in time. I was about to start working on this right
now... :-)

The original patch was to add Expat to the distribution. Feedback was to
put it into src/lib/ and to also put src/regex in there.

So, yes: aeshetics would be the reason. src/lib/ would contain complete
little blobs of code; in the regex and expat case, those blobs are
actually imported snapshots.

NOTE: I'll consider your response a veto for any src/lib/ type change
(which actually cancels my entire patch :-). Sigh...

Please let me know if you need more information, and/or please read the
recent thread "Expat patch #3" or the threads around April 15, also with
"Expat" in the subject. That should bring you up to speed.

In general, I would summarize this way:
* people want Expat in the distribution, for several independent reasons
* people feel src/lib/ is the proper location for Expat, along with
(moving) the regex stuff and adding Ralf's MM library.

Cheers,
-g

--
Greg Stein, http://www.lyra.org/

Re: [PATCH] Expat patch #3

[Rasmus Lerdorf <ra...@lerdorf.on.ca>]

> WHOA!  Why is this being done in 1.3.x???  We don't screw with the
> directory structure on minor versions, since third-party installation
> scripts depend on the directory structure not changing haphazardly.

I agree that this change is not a good idea at this point, but as for
third-party stuff needing the directory structure exactly the way it is, I
would say that the third-party install is broken.  For DSO builds, apxs
does a good job.  And for static builds, as long as src/include is updated
correctly, there shouldn't be a problem either.  As long as src/include
and src/os/* stay where they are and point to other files in the correct
places, just about anything else can be moved around.

-Rasmus