[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #34599:
URL: https://github.com/apache/spark/pull/34599#discussion_r759908300



##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
##########
@@ -381,4 +382,21 @@ object KubernetesUtils extends Logging {
       }
     }
   }
+
+  @Since("3.3.0")
+  def createOrReplaceResource(

Review comment:
       Given the function semantic is destructive (destroying the owner pod), `createOrReplaceResource` looks inadequite to me. We should have more explicit name which warns the pod deletion.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org