You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2017/02/27 19:03:50 UTC
Review Request 57099: Good coding practice in Ranger recommended by
static code analysis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57099/
-----------------------------------------------------------
Review request for ranger, Madhan Neethiraj and Ramesh Mani.
Bugs: RANGER-1413
https://issues.apache.org/jira/browse/RANGER-1413
Repository: ranger
Description
-------
Fix potention run-time issues uncovered by static code analysis.
Diffs
-----
agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/TestDefaultPolicyResourceMatcherForPolicy.java f4d76ad
Diff: https://reviews.apache.org/r/57099/diff/
Testing
-------
Ran unit tests successfully.
Thanks,
Abhay Kulkarni
Re: Review Request 57099: Good coding practice in Ranger recommended
by static code analysis
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57099/#review166923
-----------------------------------------------------------
Fix it, then Ship it!
Fix it and ship it
agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/TestDefaultPolicyResourceMatcherForPolicy.java (line 137)
<https://reviews.apache.org/r/57099/#comment239009>
class level object need not be initialized
- Ramesh Mani
On Feb. 27, 2017, 7:03 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57099/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2017, 7:03 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
>
>
> Bugs: RANGER-1413
> https://issues.apache.org/jira/browse/RANGER-1413
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fix potention run-time issues uncovered by static code analysis.
>
>
> Diffs
> -----
>
> agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/TestDefaultPolicyResourceMatcherForPolicy.java f4d76ad
>
> Diff: https://reviews.apache.org/r/57099/diff/
>
>
> Testing
> -------
>
> Ran unit tests successfully.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 57099: Good coding practice in Ranger recommended
by static code analysis
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57099/#review166924
-----------------------------------------------------------
Ship it!
Ship It!
- Ramesh Mani
On Feb. 27, 2017, 7:43 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57099/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2017, 7:43 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
>
>
> Bugs: RANGER-1413
> https://issues.apache.org/jira/browse/RANGER-1413
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fix potention run-time issues uncovered by static code analysis.
>
>
> Diffs
> -----
>
> agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/TestDefaultPolicyResourceMatcherForPolicy.java f4d76ad
>
> Diff: https://reviews.apache.org/r/57099/diff/
>
>
> Testing
> -------
>
> Ran unit tests successfully.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 57099: Good coding practice in Ranger recommended
by static code analysis
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57099/
-----------------------------------------------------------
(Updated Feb. 27, 2017, 7:43 p.m.)
Review request for ranger, Madhan Neethiraj and Ramesh Mani.
Changes
-------
Addressed review comments
Bugs: RANGER-1413
https://issues.apache.org/jira/browse/RANGER-1413
Repository: ranger
Description
-------
Fix potention run-time issues uncovered by static code analysis.
Diffs (updated)
-----
agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/TestDefaultPolicyResourceMatcherForPolicy.java f4d76ad
Diff: https://reviews.apache.org/r/57099/diff/
Testing
-------
Ran unit tests successfully.
Thanks,
Abhay Kulkarni