You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2018/11/20 16:40:00 UTC
[jira] [Commented] (SOLR-12398) Make JSON Facet API support Heatmap
Facet
[ https://issues.apache.org/jira/browse/SOLR-12398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693462#comment-16693462 ]
David Smiley commented on SOLR-12398:
-------------------------------------
Someone else just told me about this. Here is my write-up:
Solr 7.5 added heatmap support to JSON Facets. This involved a large refactor of code moving around. One change was using SimpleOrderedMap instead of NamedList directly. I don't recall why I made this change (perhaps consistency with observing some JSON Facet module code?) but my present enlightenment of the consequence is that it effectively changed the response structure to the existing classic/simple facet.heatmap when the response is JSON. SimpleOrderedMap is what it ought to have been all along since there are no repeating keys and it's a small map.
Choices:
* (A) bring back the old format for back-compat for facet.heatmap only for 7.6 and the remainder of the 7x. Do not bring back in 8.0; this is an improvement.
* (B) Add an upgrade note retroactively to CHANGES.txt for 7.5 and do no other change. Get this into our 7.6 release so it's published. The rationale here is that it's basically too late, relatively minor, and 8.0 users will have to change any way.
Any opinion?
CC 7.6 RM [~nknize] as it'll affect CHANGES.txt at a minimum either way
> Make JSON Facet API support Heatmap Facet
> -----------------------------------------
>
> Key: SOLR-12398
> URL: https://issues.apache.org/jira/browse/SOLR-12398
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Facet Module, faceting, JSON Request API, spatial
> Reporter: Jaime Yap
> Assignee: David Smiley
> Priority: Major
> Labels: heatmap
> Fix For: 7.5
>
> Attachments: SOLR-12398.patch, SOLR-12398.patch, repro-facet-heatmaps-response-format-change.patch
>
>
> The JSON query Facet API does not support Heatmap facets. For companies that have standardized around generating queries for the JSON query API, it is a major wart to need to also support falling back to the param encoding API in order to make use of them.
> More importantly however, given it's more natural support for nested subfacets, the JSON Query facet API is be able to compute more interesting Heatmap layers for each facet bucket. Without resorting to the older (and much more awkward) facet pivot syntax.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org