You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/07 08:38:53 UTC

[GitHub] [flink] dannycranmer commented on a change in pull request #18613: [FLINK-25574][connectors/async] Migrate AsyncSink connectors to decomposed SinkV2

dannycranmer commented on a change in pull request #18613:
URL: https://github.com/apache/flink/pull/18613#discussion_r800416433



##########
File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsSink.java
##########
@@ -131,8 +129,33 @@
 
     @Internal
     @Override
-    public Optional<SimpleVersionedSerializer<Collection<PutRecordsRequestEntry>>>
+    public StatefulSinkWriter<InputT, Collection<PutRecordsRequestEntry>> restoreWriter(
+            InitContext context, Collection<Collection<PutRecordsRequestEntry>> recoveredState)
+            throws IOException {
+        // TODO: Is it correct that the kinesis sink does not restore the state?

Review comment:
       As discussed this is not correct, we will fix before feature freeze. Thanks 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org