[GitHub] [kafka] xvrl commented on a change in pull request #11201: MINOR: fix mbean tag name ordering in JMX reporter

[GitBox <gi...@apache.org>]

xvrl commented on a change in pull request #11201:
URL: https://github.com/apache/kafka/pull/11201#discussion_r688708853



##########
File path: clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java
##########
@@ -76,6 +77,21 @@ public void testJmxRegistration() throws Exception {
         }
     }
 
+    @Test
+    public void testMbeanTagOrdering() {
+        Map<String, String> tags = new HashMap<>();
+        tags.put("tag_a", "x");
+        tags.put("tag_b", "y");
+        tags.put("tag_c", "z");
+        tags.put("tag_d", "1,2");
+        tags.put("tag_e", "");
+        tags.put("tag_f", "3");

Review comment:
       the test already fails if I remove the ordering code, but I can change the order if that makes us feel better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org