[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #10854: [WIP] support encode in user thread, optimize decode in user thread

[GitBox <gi...@apache.org>]

AlbumenJ commented on code in PR #10854:
URL: https://github.com/apache/dubbo/pull/10854#discussion_r1011032608


##########
dubbo-common/src/main/java/org/apache/dubbo/common/constants/CommonConstants.java:
##########
@@ -600,4 +600,8 @@ public interface CommonConstants {
      *
      */
     String DUBBO_JSTACK_MAXLINE = "dubbo.jstack-dump.max-line";
+
+
+    String ENCODE_IN_IO_THREAD_KEY = "encode.in.io";
+    boolean DEFAULT_ENCODE_IN_IO_THREAD = true;

Review Comment:
   If this doesn't break usage for some users, we can enable it by default. By the way, this PR will be merged into the `3.2` branch, which can accept some breaking changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org