You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by nd...@apache.org on 2024/03/07 20:45:01 UTC
(hbase) branch branch-2.6 updated: HBASE-23324 Deprecate clients that connect to Zookeeper (#5745)
This is an automated email from the ASF dual-hosted git repository.
ndimiduk pushed a commit to branch branch-2.6
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2.6 by this push:
new a4640616612 HBASE-23324 Deprecate clients that connect to Zookeeper (#5745)
a4640616612 is described below
commit a4640616612d6f438f48c808b3374155eb623359
Author: Nick Dimiduk <nd...@apache.org>
AuthorDate: Thu Mar 7 18:33:25 2024 +0100
HBASE-23324 Deprecate clients that connect to Zookeeper (#5745)
Our objective is to remove ZooKeeper from our public interface, remaking it as an internal
concern. Connecting to a cluster via ZooKeeper quorum will be considered deprecated starting in
2.6. Our default connection mechanism will switch to via RPC in 3.0 And finally we intend to
remove the ZooKeeper connection mechanism from client-facing APIs in 4.0.
Signed-off-by: Bryan Beaudreault <bb...@apache.org>
---
.../hadoop/hbase/client/ZKConnectionRegistry.java | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKConnectionRegistry.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKConnectionRegistry.java
index 86fd91ebabf..6ef3d1c947d 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKConnectionRegistry.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKConnectionRegistry.java
@@ -36,6 +36,7 @@ import java.util.stream.Collectors;
import org.apache.commons.lang3.mutable.MutableInt;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hbase.ClusterId;
+import org.apache.hadoop.hbase.HBaseInterfaceAudience;
import org.apache.hadoop.hbase.HRegionLocation;
import org.apache.hadoop.hbase.RegionLocations;
import org.apache.hadoop.hbase.ServerName;
@@ -54,20 +55,37 @@ import org.apache.hadoop.hbase.shaded.protobuf.generated.ZooKeeperProtos;
/**
* Zookeeper based registry implementation.
+ * @deprecated As of 2.6.0, replaced by {@link RpcConnectionRegistry}, which is the default
+ * connection mechanism as of 3.0.0. Expected to be removed in 4.0.0.
+ * @see <a href="https://issues.apache.org/jira/browse/HBASE-23324">HBASE-23324</a> and its parent
+ * ticket for details.
*/
-@InterfaceAudience.Private
+@Deprecated
+@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)
class ZKConnectionRegistry implements ConnectionRegistry {
private static final Logger LOG = LoggerFactory.getLogger(ZKConnectionRegistry.class);
+ private static final Object WARN_LOCK = new Object();
+ private static volatile boolean NEEDS_LOG_WARN = true;
+
private final ReadOnlyZKClient zk;
private final ZNodePaths znodePaths;
// User not used, but for rpc based registry we need it
- ZKConnectionRegistry(Configuration conf, User user) {
+ ZKConnectionRegistry(Configuration conf, User ignored) {
this.znodePaths = new ZNodePaths(conf);
this.zk = new ReadOnlyZKClient(conf);
+ if (NEEDS_LOG_WARN) {
+ synchronized (WARN_LOCK) {
+ if (NEEDS_LOG_WARN) {
+ LOG.warn(
+ "ZKConnectionRegistry is deprecated. See https://hbase.apache.org/book.html#client.rpcconnectionregistry");
+ NEEDS_LOG_WARN = false;
+ }
+ }
+ }
}
private interface Converter<T> {