[jira] [Work logged] (ARTEMIS-3417) Disable Auto-delete queue and auto-delete address on the default broker.xml

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-3417?focusedWorklogId=635223&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635223 ]

ASF GitHub Bot logged work on ARTEMIS-3417:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Aug/21 14:55
            Start Date: 06/Aug/21 14:55
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on a change in pull request #3691:
URL: https://github.com/apache/activemq-artemis/pull/3691#discussion_r684299827



##########
File path: artemis-cli/src/test/java/org/apache/activemq/cli/test/ArtemisTest.java
##########
@@ -749,7 +751,6 @@ public void testMissingUserFileViaManagement() throws Exception {
 
       File userFile = new File(instance1.getAbsolutePath() + "/etc/artemis-users.properties");
       userFile.delete();
-      //      File roleFile = new File(instance1.getAbsolutePath() + "/etc/artemis-roles.properties");

Review comment:
       non related to my change but I want to use the opportunity to remove this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 635223)
    Remaining Estimate: 0h
            Time Spent: 10m

> Disable Auto-delete queue and auto-delete address on the default broker.xml
> ---------------------------------------------------------------------------
>
>                 Key: ARTEMIS-3417
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3417
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Clebert Suconic
>            Assignee: Clebert Suconic
>            Priority: Major
>             Fix For: 2.18.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This is not to change defaults anywhere.. Just changing the default broker.xml
>  
> I have had lots of issues (with my own tests) and with users having issues on deleting queue and addresses by default.
>  
> The semantic to auto-delete an address is to have the queue or address gone when there are no messages or consumers on a queue. This fails in a lot of circumstances while it still provide some good usage if really intended.
>  
>  
> So, with that in hand, I'm setting the default to false on the broker.xml, and users can always change it to true by either editing the XML, or using some attributed passed on the CLI allowing the auto-delete. (--allow-auto-delete)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)