You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/03/31 07:22:19 UTC
[GitHub] [fineract] xurror opened a new pull request #748: FINERACT-783
xurror opened a new pull request #748: FINERACT-783
URL: https://github.com/apache/fineract/pull/748
- Update README.md with instructions for kubernetes
- Setup fineractmysql configuration file
- Setup fineract-server configuration file
closes https://issues.apache.org/jira/browse/FINERACT-783
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
xurror commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r402063088
##########
File path: kubernetes/fineractmysql-deployment.yml
##########
@@ -0,0 +1,110 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: v1
+kind: PersistentVolume
+metadata:
+ name: fineractmysql-pv-volume
+ labels:
+ type: local
+spec:
+ storageClassName: manual
+ capacity:
+ storage: 10Gi
+ accessModes:
+ - ReadWriteMany
+ hostPath:
+ path: "/mnt/data"
+---
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+ name: fineractmysql-pv-claim
+spec:
+ storageClassName: manual
+ accessModes:
+ - ReadWriteMany
+ resources:
+ requests:
+ storage: 5Gi
+---
+apiVersion: v1
+kind: Service
+metadata:
+ labels:
+ app: fineract-server
+ name: fineractmysql
+spec:
+ ports:
+ - protocol: TCP
+ port: 3306
+ targetPort: 3306
+ selector:
+ app: fineract-server
+ tier: fineractmysql
+ clusterIP: None
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ labels:
+ app: fineract-server
+ name: fineractmysql
+spec:
+ selector:
+ matchLabels:
+ app: fineract-server
+ tier: fineractmysql
+ strategy:
+ type: Recreate
+ template:
+ metadata:
+ labels:
+ app: fineract-server
+ tier: fineractmysql
+ spec:
+ containers:
+ - image: mysql:5.7
+ name: mysql
+ env:
+ - name: MYSQL_ROOT_PASSWORD
+ value: skdcnwauicn2ucnaecasdsajdnizucawencascdca
+ livenessProbe:
+ exec:
+ command:
+ - mysqladmin
+ - ping
+ - -h
+ - localhost
+ failureThreshold: 10
+ timeoutSeconds: 10
+ ports:
+ - containerPort: 3306
+ name: fineractmysql
+ volumeMounts:
+ - name: fineractmysql-persistent-storage
+ mountPath: /var/lib/mysql/
+ - name: fineractmysql-host-path
+ mountPath: /docker-entrypoint-initdb.d/
+ volumes:
+ - name: fineractmysql-persistent-storage
+ persistentVolumeClaim:
+ claimName: fineractmysql-pv-claim
Review comment:
No, a PV is created manually and claimed by fineractmysql for storage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
xurror commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r402064491
##########
File path: kubernetes/fineract-server-deployment.yml
##########
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: v1
+kind: Service
+metadata:
+ labels:
+ app: fineract-server
+ name: fineract-server
+spec:
+ ports:
+ - protocol: TCP
+ port: 8443
+ targetPort: 8443
+ nodePort: 30443
+ selector:
+ app: fineract-server
+ tier: backend
+ type: LoadBalancer
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ name: fineract-server
+ labels:
+ app: fineract-server
+spec:
+ selector:
+ matchLabels:
+ app: fineract-server
+ tier: backend
+ strategy:
+ type: Recreate
+ template:
+ metadata:
+ labels:
+ app: fineract-server
+ tier: backend
+ spec:
+ containers:
+ - name: fineract-server
+ image: apache/fineract:latest
+ env:
+ - name: JAVA_OPTS
+ value: -Dfineract_tenants_url=jdbc:mysql:thin://fineractmysql:3306/fineract_tenants -Dfineract_tenants_driver=org.drizzle.jdbc.DrizzleDriver -Dfineract_tenants_uid=root -Dfineract_tenants_pwd=skdcnwauicn2ucnaecasdsajdnizucawencascdca -Djava.awt.headless=true -XX:+UseG1GC -Dfile.encoding=UTF-8
+ - name: FINERACT_DEFAULT_TENANTDB_HOSTNAME
+ value: fineractmysql
+ - name: FINERACT_DEFAULT_TENANTDB_PORT
+ value: '3306'
+ - name: FINERACT_DEFAULT_TENANTDB_UID
+ value: root
+ - name: FINERACT_DEFAULT_TENANTDB_PWD
+ value: skdcnwauicn2ucnaecasdsajdnizucawencascdca
Review comment:
I will setup the secrets in this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror commented on issue #748: Fineract on
Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
xurror commented on issue #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#issuecomment-607196254
It passes now. Not sure why it failed before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r401843193
##########
File path: kubernetes/fineract-server-deployment.yml
##########
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: v1
+kind: Service
+metadata:
+ labels:
+ app: fineract-server
+ name: fineract-server
+spec:
+ ports:
+ - protocol: TCP
+ port: 8443
+ targetPort: 8443
+ nodePort: 30443
Review comment:
I am wondering if we could avoid using this? What exactly is this required for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r401847487
##########
File path: kubernetes/fineract-server-deployment.yml
##########
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: v1
+kind: Service
+metadata:
+ labels:
+ app: fineract-server
+ name: fineract-server
+spec:
+ ports:
+ - protocol: TCP
+ port: 8443
+ targetPort: 8443
+ nodePort: 30443
+ selector:
+ app: fineract-server
+ tier: backend
+ type: LoadBalancer
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ name: fineract-server
+ labels:
+ app: fineract-server
+spec:
+ selector:
+ matchLabels:
+ app: fineract-server
+ tier: backend
+ strategy:
+ type: Recreate
+ template:
+ metadata:
+ labels:
+ app: fineract-server
+ tier: backend
+ spec:
+ containers:
+ - name: fineract-server
+ image: apache/fineract:latest
+ env:
+ - name: JAVA_OPTS
+ value: -Dfineract_tenants_url=jdbc:mysql:thin://fineractmysql:3306/fineract_tenants -Dfineract_tenants_driver=org.drizzle.jdbc.DrizzleDriver -Dfineract_tenants_uid=root -Dfineract_tenants_pwd=skdcnwauicn2ucnaecasdsajdnizucawencascdca -Djava.awt.headless=true -XX:+UseG1GC -Dfile.encoding=UTF-8
+ - name: FINERACT_DEFAULT_TENANTDB_HOSTNAME
+ value: fineractmysql
+ - name: FINERACT_DEFAULT_TENANTDB_PORT
+ value: '3306'
+ - name: FINERACT_DEFAULT_TENANTDB_UID
+ value: root
+ - name: FINERACT_DEFAULT_TENANTDB_PWD
+ value: skdcnwauicn2ucnaecasdsajdnizucawencascdca
Review comment:
Normally one would use a Kubernetes Secret for this instead.. of course, that could be done later as well, but I'm concerned having a default password here is asking for trouble.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] Anh3h commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
Anh3h commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r403707357
##########
File path: README.md
##########
@@ -107,6 +107,30 @@ _(Note that in previous versions, the `mysqlserver` environment variable used at
and the `mysqlserver` environment variable is now no longer supported.)_
+Instructions to run using minikube and kubectl
+===================================================
+
+You can also run Fineract using containers on a kubernetes cluster.
+
+As Prerequisites, you must have `minikube` and `kubectl` installed on your machine; see
+[Minikube & Kubectl install](https://kubernetes.io/docs/tasks/tools/install-minikube/).
Review comment:
Just an addon but can you update the readme and deployment scripts (if necessary) to show how someone can deploy on other Kubernetes deployment platforms not necessarily mini-kube.
Plus I faced some issues installing mini-kube locally, I would like to help test your scripts but I would like to try on an online option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror commented on issue #748: Fineract on
Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
xurror commented on issue #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#issuecomment-607082781
I can at least confirm that the kubernetes deployment worked fine on pc though the tests are failing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
xurror commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r403716501
##########
File path: README.md
##########
@@ -107,6 +107,30 @@ _(Note that in previous versions, the `mysqlserver` environment variable used at
and the `mysqlserver` environment variable is now no longer supported.)_
+Instructions to run using minikube and kubectl
+===================================================
+
+You can also run Fineract using containers on a kubernetes cluster.
+
+As Prerequisites, you must have `minikube` and `kubectl` installed on your machine; see
+[Minikube & Kubectl install](https://kubernetes.io/docs/tasks/tools/install-minikube/).
+
+Now to run a new Fineract instance on minikube you can simply:
+
+1. `git clone https://github.com/apache/fineract.git ; cd fineract`
+1. `minikube start --mount-string="./fineract-db/docker:/fineract-db" --mount --vm-driver=virtualbox`
+1. `kubectl apply -f kubernetes/secrets.yml`
+1. `kubectl apply -f kubernetes/fineractmysql-deployment.yml`
Review comment:
The readme when previewed, displays the steps in an incremental order
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
xurror commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r402061721
##########
File path: kubernetes/fineractmysql-deployment.yml
##########
@@ -0,0 +1,110 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: v1
+kind: PersistentVolume
+metadata:
+ name: fineractmysql-pv-volume
+ labels:
+ type: local
+spec:
+ storageClassName: manual
+ capacity:
+ storage: 10Gi
+ accessModes:
+ - ReadWriteMany
+ hostPath:
+ path: "/mnt/data"
+---
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+ name: fineractmysql-pv-claim
+spec:
+ storageClassName: manual
+ accessModes:
+ - ReadWriteMany
+ resources:
+ requests:
+ storage: 5Gi
+---
+apiVersion: v1
+kind: Service
+metadata:
+ labels:
+ app: fineract-server
+ name: fineractmysql
+spec:
+ ports:
+ - protocol: TCP
+ port: 3306
+ targetPort: 3306
+ selector:
+ app: fineract-server
+ tier: fineractmysql
+ clusterIP: None
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ labels:
+ app: fineract-server
+ name: fineractmysql
+spec:
+ selector:
+ matchLabels:
+ app: fineract-server
+ tier: fineractmysql
+ strategy:
+ type: Recreate
+ template:
+ metadata:
+ labels:
+ app: fineract-server
+ tier: fineractmysql
+ spec:
+ containers:
+ - image: mysql:5.7
+ name: mysql
+ env:
+ - name: MYSQL_ROOT_PASSWORD
+ value: skdcnwauicn2ucnaecasdsajdnizucawencascdca
+ livenessProbe:
+ exec:
+ command:
+ - mysqladmin
+ - ping
+ - -h
+ - localhost
+ failureThreshold: 10
+ timeoutSeconds: 10
+ ports:
+ - containerPort: 3306
+ name: fineractmysql
+ volumeMounts:
+ - name: fineractmysql-persistent-storage
+ mountPath: /var/lib/mysql/
+ - name: fineractmysql-host-path
+ mountPath: /docker-entrypoint-initdb.d/
+ volumes:
+ - name: fineractmysql-persistent-storage
+ persistentVolumeClaim:
+ claimName: fineractmysql-pv-claim
+ - name: fineractmysql-host-path
+ hostPath:
+ path: /fineract-db
Review comment:
I had some trouble using configMap, so with all the failures from before, I tried to focus on a solution that works first. And then lateron modifications can be done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror commented on issue #748: Fineract on
Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
xurror commented on issue #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#issuecomment-607082226
Yeah, it can't be helped. The failed tests do not relate to the changes I have made in this PR. I tried running the tests locally and even on branch develop and they keep failing.
These failures look slot like those caused by the flaky integration tests I reported before.
I thought they were resolved. Not sure why it's happening again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #748: Fineract on
Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#issuecomment-612585231
> We also need someone to actually try this out (follow this README, confirm it works).. any volunteers?
I've just tested this myself, and can confirm that it works as advertised! I'll merge this. @xurror great job!!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r401849114
##########
File path: kubernetes/fineractmysql-deployment.yml
##########
@@ -0,0 +1,110 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: v1
+kind: PersistentVolume
+metadata:
+ name: fineractmysql-pv-volume
+ labels:
+ type: local
+spec:
+ storageClassName: manual
+ capacity:
+ storage: 10Gi
+ accessModes:
+ - ReadWriteMany
+ hostPath:
+ path: "/mnt/data"
+---
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+ name: fineractmysql-pv-claim
+spec:
+ storageClassName: manual
+ accessModes:
+ - ReadWriteMany
+ resources:
+ requests:
+ storage: 5Gi
+---
+apiVersion: v1
+kind: Service
+metadata:
+ labels:
+ app: fineract-server
+ name: fineractmysql
+spec:
+ ports:
+ - protocol: TCP
+ port: 3306
+ targetPort: 3306
+ selector:
+ app: fineract-server
+ tier: fineractmysql
+ clusterIP: None
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ labels:
+ app: fineract-server
+ name: fineractmysql
+spec:
+ selector:
+ matchLabels:
+ app: fineract-server
+ tier: fineractmysql
+ strategy:
+ type: Recreate
+ template:
+ metadata:
+ labels:
+ app: fineract-server
+ tier: fineractmysql
+ spec:
+ containers:
+ - image: mysql:5.7
+ name: mysql
+ env:
+ - name: MYSQL_ROOT_PASSWORD
+ value: skdcnwauicn2ucnaecasdsajdnizucawencascdca
+ livenessProbe:
+ exec:
+ command:
+ - mysqladmin
+ - ping
+ - -h
+ - localhost
+ failureThreshold: 10
+ timeoutSeconds: 10
+ ports:
+ - containerPort: 3306
+ name: fineractmysql
+ volumeMounts:
+ - name: fineractmysql-persistent-storage
+ mountPath: /var/lib/mysql/
+ - name: fineractmysql-host-path
+ mountPath: /docker-entrypoint-initdb.d/
+ volumes:
+ - name: fineractmysql-persistent-storage
+ persistentVolumeClaim:
+ claimName: fineractmysql-pv-claim
Review comment:
Does this PV get automatically created?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on issue #748: Fineract on
Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#issuecomment-607201334
@vorburger , @Anh3h , @conradsp , Please review and provide feedback on this given your Docker related contributions on Fineract.
Good work @xurror , to make this usable and to pass Travis Test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror edited a comment on issue #748: FINERACT-783
Posted by GitBox <gi...@apache.org>.
xurror edited a comment on issue #748: FINERACT-783
URL: https://github.com/apache/fineract/pull/748#issuecomment-606449081
Working solution for #651.
Needs functional review.
@Anh3h @vorburger @mohitsinha please can you check this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror commented on issue #748: FINERACT-783
Posted by GitBox <gi...@apache.org>.
xurror commented on issue #748: FINERACT-783
URL: https://github.com/apache/fineract/pull/748#issuecomment-606449081
Working solution for #651.
Needs functional review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] Anh3h commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
Anh3h commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r403707357
##########
File path: README.md
##########
@@ -107,6 +107,30 @@ _(Note that in previous versions, the `mysqlserver` environment variable used at
and the `mysqlserver` environment variable is now no longer supported.)_
+Instructions to run using minikube and kubectl
+===================================================
+
+You can also run Fineract using containers on a kubernetes cluster.
+
+As Prerequisites, you must have `minikube` and `kubectl` installed on your machine; see
+[Minikube & Kubectl install](https://kubernetes.io/docs/tasks/tools/install-minikube/).
Review comment:
Just an addon but can you update the readme and deployment scripts (if necessary) to show how someone can deploy on other Kubernetes deployment platforms not necessarily mini-kube.
Plus I faced some issues installing mini-kube locally, I would like to help to test your scripts but I would like to try on an online option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r402131698
##########
File path: kubernetes/fineract-server-deployment.yml
##########
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: v1
+kind: Service
+metadata:
+ labels:
+ app: fineract-server
+ name: fineract-server
+spec:
+ ports:
+ - protocol: TCP
+ port: 8443
+ targetPort: 8443
+ nodePort: 30443
Review comment:
I meant specifically only the NodePort.. why is that required here? minikube service --irl (hopefully) doesn't need that, or does it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] thesmallstar commented on issue #748: Fineract on
Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on issue #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#issuecomment-606868382
hello @xurror, the build is failing integration tests can you please check it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror commented on issue #748: Fineract on
Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
xurror commented on issue #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#issuecomment-612551401
Taking into consideration the review by @Anh3h and @vorburger , I took upon myself to implement the configMap in this PR so we don't have to mount directories anymore. Also I've tried to mimic what has been done with fineract-cn-docker-compose by implementing scripts and also adapting the readme to be run first on kubernetes(GKE) and alternatively on minikube for those who want to test it locally.
So @Anh3h, if you still have the time, can you try this online?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror closed pull request #748: Fineract on
Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
xurror closed pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
xurror commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r406354952
##########
File path: README.md
##########
@@ -107,6 +107,30 @@ _(Note that in previous versions, the `mysqlserver` environment variable used at
and the `mysqlserver` environment variable is now no longer supported.)_
+Instructions to run using minikube and kubectl
+===================================================
+
+You can also run Fineract using containers on a kubernetes cluster.
+
+As Prerequisites, you must have `minikube` and `kubectl` installed on your machine; see
+[Minikube & Kubectl install](https://kubernetes.io/docs/tasks/tools/install-minikube/).
Review comment:
Unfortunately I don't have the resources needed to use an online cluster such GCP/AWS/Azure...
But It will be definitely good to have that in a readme but the configuration should work all thesame. We will be a little stuck at the level of the `minikube start --mount` but that will get fixed up in a follow up PR and also setup bash scripts to automate all the steps used.
But to the best of my knowledge the configuration should work on thesame.
I found an online playground where you can test the configs as per the readme.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror opened a new pull request #748: Fineract on
Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
xurror opened a new pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748
- Update README.md with instructions for kubernetes
- Setup fineractmysql configuration file
- Setup fineract-server configuration file
closes https://issues.apache.org/jira/browse/FINERACT-783
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
xurror commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r406356632
##########
File path: README.md
##########
@@ -107,6 +107,30 @@ _(Note that in previous versions, the `mysqlserver` environment variable used at
and the `mysqlserver` environment variable is now no longer supported.)_
+Instructions to run using minikube and kubectl
+===================================================
+
+You can also run Fineract using containers on a kubernetes cluster.
+
+As Prerequisites, you must have `minikube` and `kubectl` installed on your machine; see
+[Minikube & Kubectl install](https://kubernetes.io/docs/tasks/tools/install-minikube/).
Review comment:
I'll update the readme with that, but it doesn't seem very ideale to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r401847731
##########
File path: kubernetes/fineractmysql-deployment.yml
##########
@@ -0,0 +1,110 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: v1
+kind: PersistentVolume
+metadata:
+ name: fineractmysql-pv-volume
+ labels:
+ type: local
+spec:
+ storageClassName: manual
+ capacity:
+ storage: 10Gi
+ accessModes:
+ - ReadWriteMany
+ hostPath:
+ path: "/mnt/data"
+---
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+ name: fineractmysql-pv-claim
+spec:
+ storageClassName: manual
+ accessModes:
+ - ReadWriteMany
+ resources:
+ requests:
+ storage: 5Gi
+---
+apiVersion: v1
+kind: Service
+metadata:
+ labels:
+ app: fineract-server
+ name: fineractmysql
+spec:
+ ports:
+ - protocol: TCP
+ port: 3306
+ targetPort: 3306
+ selector:
+ app: fineract-server
+ tier: fineractmysql
+ clusterIP: None
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ labels:
+ app: fineract-server
+ name: fineractmysql
+spec:
+ selector:
+ matchLabels:
+ app: fineract-server
+ tier: fineractmysql
+ strategy:
+ type: Recreate
+ template:
+ metadata:
+ labels:
+ app: fineract-server
+ tier: fineractmysql
+ spec:
+ containers:
+ - image: mysql:5.7
+ name: mysql
+ env:
+ - name: MYSQL_ROOT_PASSWORD
+ value: skdcnwauicn2ucnaecasdsajdnizucawencascdca
Review comment:
as above, re PWD
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] Anh3h commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
Anh3h commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r403706894
##########
File path: README.md
##########
@@ -107,6 +107,30 @@ _(Note that in previous versions, the `mysqlserver` environment variable used at
and the `mysqlserver` environment variable is now no longer supported.)_
+Instructions to run using minikube and kubectl
+===================================================
+
+You can also run Fineract using containers on a kubernetes cluster.
+
+As Prerequisites, you must have `minikube` and `kubectl` installed on your machine; see
+[Minikube & Kubectl install](https://kubernetes.io/docs/tasks/tools/install-minikube/).
+
+Now to run a new Fineract instance on minikube you can simply:
+
+1. `git clone https://github.com/apache/fineract.git ; cd fineract`
+1. `minikube start --mount-string="./fineract-db/docker:/fineract-db" --mount --vm-driver=virtualbox`
+1. `kubectl apply -f kubernetes/secrets.yml`
+1. `kubectl apply -f kubernetes/fineractmysql-deployment.yml`
Review comment:
All the steps are labelled 1. can you use dots instead or increment the labels?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] Anh3h commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
Anh3h commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r403707357
##########
File path: README.md
##########
@@ -107,6 +107,30 @@ _(Note that in previous versions, the `mysqlserver` environment variable used at
and the `mysqlserver` environment variable is now no longer supported.)_
+Instructions to run using minikube and kubectl
+===================================================
+
+You can also run Fineract using containers on a kubernetes cluster.
+
+As Prerequisites, you must have `minikube` and `kubectl` installed on your machine; see
+[Minikube & Kubectl install](https://kubernetes.io/docs/tasks/tools/install-minikube/).
Review comment:
Just an addon but can update the readme and deployment scripts (if necessary) to show how someone can deploy on other Kubernetes deployment platforms not necessarily mini-kube.
Cause the focus is on Kubernetes, not mini-kube
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r402132520
##########
File path: kubernetes/fineractmysql-deployment.yml
##########
@@ -0,0 +1,110 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: v1
+kind: PersistentVolume
+metadata:
+ name: fineractmysql-pv-volume
+ labels:
+ type: local
+spec:
+ storageClassName: manual
+ capacity:
+ storage: 10Gi
+ accessModes:
+ - ReadWriteMany
+ hostPath:
+ path: "/mnt/data"
+---
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+ name: fineractmysql-pv-claim
+spec:
+ storageClassName: manual
+ accessModes:
+ - ReadWriteMany
+ resources:
+ requests:
+ storage: 5Gi
+---
+apiVersion: v1
+kind: Service
+metadata:
+ labels:
+ app: fineract-server
+ name: fineractmysql
+spec:
+ ports:
+ - protocol: TCP
+ port: 3306
+ targetPort: 3306
+ selector:
+ app: fineract-server
+ tier: fineractmysql
+ clusterIP: None
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ labels:
+ app: fineract-server
+ name: fineractmysql
+spec:
+ selector:
+ matchLabels:
+ app: fineract-server
+ tier: fineractmysql
+ strategy:
+ type: Recreate
+ template:
+ metadata:
+ labels:
+ app: fineract-server
+ tier: fineractmysql
+ spec:
+ containers:
+ - image: mysql:5.7
+ name: mysql
+ env:
+ - name: MYSQL_ROOT_PASSWORD
+ value: skdcnwauicn2ucnaecasdsajdnizucawencascdca
+ livenessProbe:
+ exec:
+ command:
+ - mysqladmin
+ - ping
+ - -h
+ - localhost
+ failureThreshold: 10
+ timeoutSeconds: 10
+ ports:
+ - containerPort: 3306
+ name: fineractmysql
+ volumeMounts:
+ - name: fineractmysql-persistent-storage
+ mountPath: /var/lib/mysql/
+ - name: fineractmysql-host-path
+ mountPath: /docker-entrypoint-initdb.d/
+ volumes:
+ - name: fineractmysql-persistent-storage
+ persistentVolumeClaim:
+ claimName: fineractmysql-pv-claim
+ - name: fineractmysql-host-path
+ hostPath:
+ path: /fineract-db
Review comment:
Sure, SGTM. Do you want to create a JIRA ticket for future follow up on this? Then Resolve.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
xurror commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r402142762
##########
File path: kubernetes/fineractmysql-deployment.yml
##########
@@ -0,0 +1,110 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: v1
+kind: PersistentVolume
+metadata:
+ name: fineractmysql-pv-volume
+ labels:
+ type: local
+spec:
+ storageClassName: manual
+ capacity:
+ storage: 10Gi
+ accessModes:
+ - ReadWriteMany
+ hostPath:
+ path: "/mnt/data"
+---
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+ name: fineractmysql-pv-claim
+spec:
+ storageClassName: manual
+ accessModes:
+ - ReadWriteMany
+ resources:
+ requests:
+ storage: 5Gi
+---
+apiVersion: v1
+kind: Service
+metadata:
+ labels:
+ app: fineract-server
+ name: fineractmysql
+spec:
+ ports:
+ - protocol: TCP
+ port: 3306
+ targetPort: 3306
+ selector:
+ app: fineract-server
+ tier: fineractmysql
+ clusterIP: None
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ labels:
+ app: fineract-server
+ name: fineractmysql
+spec:
+ selector:
+ matchLabels:
+ app: fineract-server
+ tier: fineractmysql
+ strategy:
+ type: Recreate
+ template:
+ metadata:
+ labels:
+ app: fineract-server
+ tier: fineractmysql
+ spec:
+ containers:
+ - image: mysql:5.7
+ name: mysql
+ env:
+ - name: MYSQL_ROOT_PASSWORD
+ value: skdcnwauicn2ucnaecasdsajdnizucawencascdca
+ livenessProbe:
+ exec:
+ command:
+ - mysqladmin
+ - ping
+ - -h
+ - localhost
+ failureThreshold: 10
+ timeoutSeconds: 10
+ ports:
+ - containerPort: 3306
+ name: fineractmysql
+ volumeMounts:
+ - name: fineractmysql-persistent-storage
+ mountPath: /var/lib/mysql/
+ - name: fineractmysql-host-path
+ mountPath: /docker-entrypoint-initdb.d/
+ volumes:
+ - name: fineractmysql-persistent-storage
+ persistentVolumeClaim:
+ claimName: fineractmysql-pv-claim
+ - name: fineractmysql-host-path
+ hostPath:
+ path: /fineract-db
Review comment:
Sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r401846648
##########
File path: kubernetes/fineractmysql-deployment.yml
##########
@@ -0,0 +1,110 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: v1
+kind: PersistentVolume
+metadata:
+ name: fineractmysql-pv-volume
+ labels:
+ type: local
+spec:
+ storageClassName: manual
+ capacity:
+ storage: 10Gi
+ accessModes:
+ - ReadWriteMany
+ hostPath:
+ path: "/mnt/data"
+---
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+ name: fineractmysql-pv-claim
+spec:
+ storageClassName: manual
+ accessModes:
+ - ReadWriteMany
+ resources:
+ requests:
+ storage: 5Gi
+---
+apiVersion: v1
+kind: Service
+metadata:
+ labels:
+ app: fineract-server
+ name: fineractmysql
+spec:
+ ports:
+ - protocol: TCP
+ port: 3306
+ targetPort: 3306
+ selector:
+ app: fineract-server
+ tier: fineractmysql
+ clusterIP: None
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ labels:
+ app: fineract-server
+ name: fineractmysql
+spec:
+ selector:
+ matchLabels:
+ app: fineract-server
+ tier: fineractmysql
+ strategy:
+ type: Recreate
+ template:
+ metadata:
+ labels:
+ app: fineract-server
+ tier: fineractmysql
+ spec:
+ containers:
+ - image: mysql:5.7
+ name: mysql
+ env:
+ - name: MYSQL_ROOT_PASSWORD
+ value: skdcnwauicn2ucnaecasdsajdnizucawencascdca
+ livenessProbe:
+ exec:
+ command:
+ - mysqladmin
+ - ping
+ - -h
+ - localhost
+ failureThreshold: 10
+ timeoutSeconds: 10
+ ports:
+ - containerPort: 3306
+ name: fineractmysql
+ volumeMounts:
+ - name: fineractmysql-persistent-storage
+ mountPath: /var/lib/mysql/
+ - name: fineractmysql-host-path
+ mountPath: /docker-entrypoint-initdb.d/
+ volumes:
+ - name: fineractmysql-persistent-storage
+ persistentVolumeClaim:
+ claimName: fineractmysql-pv-claim
+ - name: fineractmysql-host-path
+ hostPath:
+ path: /fineract-db
Review comment:
I see what you are doing, but it seems like a little bit of a shame to me that JUST for 2 lines of CREATE DB we have to do the whole mount thing... How about using a ConfigMap PV for this instead? This could also be done in a follow up PR, of course.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger merged pull request #748: Fineract on
Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror commented on a change in pull request #748:
Fineract on Kubernetes(FINERACT-783)
Posted by GitBox <gi...@apache.org>.
xurror commented on a change in pull request #748: Fineract on Kubernetes(FINERACT-783)
URL: https://github.com/apache/fineract/pull/748#discussion_r402064272
##########
File path: kubernetes/fineract-server-deployment.yml
##########
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: v1
+kind: Service
+metadata:
+ labels:
+ app: fineract-server
+ name: fineract-server
+spec:
+ ports:
+ - protocol: TCP
+ port: 8443
+ targetPort: 8443
+ nodePort: 30443
Review comment:
You mean the whole service configuration or just the nodePort?
If it's the nodePort, I set a fixed value cause kuberntes allocates one randomly in the range 3000-36..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services