You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/16 07:54:29 UTC
[GitHub] [shardingsphere] azexcy opened a new pull request, #17702: Scaling IT optimization
azexcy opened a new pull request, #17702:
URL: https://github.com/apache/shardingsphere/pull/17702
Changes proposed in this pull request:
- Scaling increment task optimization
- Replace addResource template,
- Add more print when error happened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Scaling IT optimization [shardingsphere]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17702:
URL: https://github.com/apache/shardingsphere/pull/17702#issuecomment-4178429130
## [Codecov](https://app.codecov.io/gh/apache/shardingsphere/pull/17702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `25.00000%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.81%. Comparing base ([`e52989c`](https://app.codecov.io/gh/apache/shardingsphere/commit/e52989c24ba6ee55fb83f6c0f44acb72fd257eb7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f956508`](https://app.codecov.io/gh/apache/shardingsphere/commit/f95650891aa50ebe32e4d5ce7da55a59e61f1caf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 15231 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/shardingsphere/pull/17702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...xception/ShardingSphereConfigurationException.java](https://app.codecov.io/gh/apache/shardingsphere/pull/17702?src=pr&el=tree&filepath=shardingsphere-infra%2Fshardingsphere-infra-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Fconfig%2Fexception%2FShardingSphereConfigurationException.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jb25maWcvZXhjZXB0aW9uL1NoYXJkaW5nU3BoZXJlQ29uZmlndXJhdGlvbkV4Y2VwdGlvbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere/pull/17702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ingletable/datanode/SingleTableDataNodeLoader.java](https://app.codecov.io/gh/apache/shardingsphere/pull/17702?src=pr&el=tree&filepath=shardingsphere-kernel%2Fshardingsphere-single-table%2Fshardingsphere-single-table-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsingletable%2Fdatanode%2FSingleTableDataNodeLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNpbmdsZS10YWJsZS9zaGFyZGluZ3NwaGVyZS1zaW5nbGUtdGFibGUtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2luZ2xldGFibGUvZGF0YW5vZGUvU2luZ2xlVGFibGVEYXRhTm9kZUxvYWRlci5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/shardingsphere/pull/17702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17702 +/- ##
============================================
- Coverage 58.82% 58.81% -0.01%
Complexity 2126 2126
============================================
Files 3599 3599
Lines 53570 53572 +2
Branches 9146 9146
============================================
- Hits 31510 31507 -3
- Misses 19386 19391 +5
Partials 2674 2674
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/shardingsphere/pull/17702?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #17702: Scaling IT optimization
Posted by GitBox <gi...@apache.org>.
sandynz merged PR #17702:
URL: https://github.com/apache/shardingsphere/pull/17702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org