You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (JIRA)" <ji...@apache.org> on 2015/12/12 01:22:46 UTC

[jira] [Created] (CALCITE-1024) When writing planner tests, be explicit that rule has no effect

Julian Hyde created CALCITE-1024:
------------------------------------

             Summary: When writing planner tests, be explicit that rule has no effect
                 Key: CALCITE-1024
                 URL: https://issues.apache.org/jira/browse/CALCITE-1024
             Project: Calcite
          Issue Type: Bug
            Reporter: Julian Hyde
            Assignee: Julian Hyde


Add method {{RelOptRulesTestBase.checkPlanUnchanged}} method, and also add a {{boolean unchanged}} parameter to the underlying {{checkPlanning}} method. If a planner test is supposed to have no effect, that is, if the before and after plans are the same, then you must specify that flag.

This makes it easier to notice if a rule that is supposed to work has stopped working. It also removes redundant plans from the reference file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)