You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/10 02:34:26 UTC

[GitHub] [spark] LuciferYang commented on pull request #35694: [SPARK-38360][SQL][SS][PYTHON] Introduce a `exists` function for `TreeNode` to eliminate duplicate code patterns

LuciferYang commented on pull request #35694:
URL: https://github.com/apache/spark/pull/35694#issuecomment-1063591878


   > Hmm, I'm not sure about how much it reduces duplicate code. Seems not too much? Looks like you only eliminate `isDefined`, `isEmpty`, `nonEmpty`.
   > 
   > I'm okay with the change.
   
   Yes, just a small optimization


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org