[GitHub] [airflow] mik-laj commented on a change in pull request #15100: Add support for arbitrary json in conn uri format

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #15100:
URL: https://github.com/apache/airflow/pull/15100#discussion_r606644684



##########
File path: tests/secrets/test_local_filesystem.py
##########
@@ -222,9 +222,9 @@ def test_missing_file(self, mock_exists):
                 {
                     "conn_a": "mysql://hosta",
                     "conn_b": ''.join(

Review comment:
       You changed the connection setup here.
   Before:
   ```
   >> parse_qsl(urlparse(before).query)
   [('extra__google_cloud_platform__keyfile_dict', "{'a': 'b'}"), ('extra__google_cloud_platform__keyfile_path', 'asaa')]
   ```
   After:
   ```
   >> parse_qsl(urlparse(after).query)
   '{"extra__google_cloud_platform__keyfile_dict": {"a": "b"}, "extra__google_cloud_platform__keyfile_path": "asaa"}'
   ```
   It is expected to pass JSON as text as the user enters the JSON as text. See: http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/apache-airflow-providers-google/latest/connections/gcp.html#configuring-the-connection




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org