You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/10 08:38:44 UTC

[GitHub] [maven] rmannibucau commented on a diff in pull request #950: Use proxies for session scoped beans

rmannibucau commented on code in PR #950:
URL: https://github.com/apache/maven/pull/950#discussion_r1065476794


##########
maven-core/pom.xml:
##########
@@ -144,6 +144,12 @@ under the License.
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-api</artifactId>
     </dependency>
+    <dependency>

Review Comment:
   since we already rely on build tools maybe let's just generate the proxy class at build time too and avoid to rely more on asm than the stack already does



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org