[GitHub] [incubator-skywalking] wu-sheng commented on a change in pull request #2411: Divide two static classes

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #2411: Divide two static classes
URL: https://github.com/apache/incubator-skywalking/pull/2411#discussion_r269636035
 
 

 ##########
 File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModule.java
 ##########
 @@ -48,6 +49,9 @@ public CoreModule() {
         classes.add(DownsamplingConfigService.class);
         classes.add(IComponentLibraryCatalogService.class);
 
+        classes.add(IWorkerInstanceGetter.class);
+        classes.add(IWorkerInstanceSetter.class);
 
 Review comment:
   How about call these two as WorkerInstanceManager? Setter/Getter looks too abstract as a service to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services