You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "claudio4j (via GitHub)" <gi...@apache.org> on 2023/03/13 12:01:05 UTC

[GitHub] [camel-k] claudio4j commented on a diff in pull request #4120: fix(knative): Integration in error state when knative SinkBinding mode=inclusion

claudio4j commented on code in PR #4120:
URL: https://github.com/apache/camel-k/pull/4120#discussion_r1133823708


##########
e2e/yaks/common/knative-sinkbinding-http/sinkbinding.feature:
##########
@@ -0,0 +1,9 @@
+Feature: Camel K can run source HTTP endpoint in sinkbinding mode
+
+  Background:
+    Given Kubernetes resource polling configuration
+      | maxAttempts          | 1   |
+      | delayBetweenAttempts | 500 |
+
+  Scenario: Integration knative-service starts with no errors
+    Given wait for condition=Ready on Kubernetes custom resource integration/rest2channel in integration.camel.apache.org/v1

Review Comment:
   To provoke the error, the integration starts and keeps on `Running` phase for some seconds to later fail with `java.lang.IllegalArgumentException: Unable to find a resource definition for channel/sink/messages`, then the integration ping pong between Running and Error. In this case the yaks test `Given Camel K integration` returns true when it matches the `Running` phase.
   
   I found out using the custom k8s resource test worked best.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org